[LG-7684] Make state optional for OIDC Logout#7045
Merged
Conversation
pauldoomgov
reviewed
Sep 28, 2022
Contributor
pauldoomgov
left a comment
pauldoomgov
left a comment
There was a problem hiding this comment.
I will let a qualified Ruby dev approve, but this looks good to me!
orenyk
force-pushed
the
oyk-logout-state-optional
branch
from
31425df to
1e6ae1d
Compare
Resolves LG-7684 This brings us in alignment with the spec. changelog: Improvements, Authentication, Make state optional for OIDC Logout
orenyk
force-pushed
the
oyk-logout-state-optional
branch
from
1e6ae1d to
a73bc90
Compare
Contributor
Author
|
@mitchellhenke I rebased on top of |
mdiarra3
approved these changes
Sep 29, 2022
mitchellhenke
approved these changes
Sep 29, 2022
Merged
jskinne3
pushed a commit
that referenced
this pull request
Oct 12, 2022
Resolves LG-7684 This brings us in alignment with the spec. changelog: Improvements, Authentication, Make state optional for OIDC Logout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves LG-7684
This brings us in alignment with the spec.
changelog: Improvements, Authentication, Make state optional for OIDC Logout
🎫 Ticket
https://cm-jira.usa.gov/browse/LG-7684
🛠 Summary of changes
OIDC Logout no longer requires the
stateparameter to match the spec.📜 Testing Plan
🚀 Notes for Deployment
N/A