Merged
Conversation
…#6546) * Use 'Update' buttons. Use sentence case * First pass at making copy changes * Fix zipcode key * Finish moving translation strings * Use description list on verify page * changelog: Improvements, Verify and update pages, Consistently use 'Update' language instead of 'Change' * Fix indentation issues * Normalize yamls * Fix broken specs * Make font sizes consistent * Remove unnecessary left margins * Update English aria labels * Fix i18n typos and capitalization
…ancel (#6542) * LG-5258: Allow users to start over IAL2 verification after clicking Cancel **Why**: As an end user, I expect that when I click Cancel, I will see an option to start over the identity verification process (IAL2), so that I can try to verify my identity again if I do not want to abandon the process completely. changelog: Improvements, Identity Verification, Revise cancellation screen to allow user to start over * Remove reference to "Start Over" link * Remove unnecessary references to "Start Over URL" No longer managed by the React applications, since the choice to start over is moved into the cancellation experience. * Rename click_spinner_button to click_spinner_button_and_wait See: #6542 (comment) Co-Authored-By: Zach Margolis <zbmargolis@gmail.com> * Try simplified click_idv_continue If it turns out to be necessary to pull into viewport, might be good to have in base behavior anyways Also unsure if we still have multiple instances of "Continue" on the same screen in IdV Alternatively, update click_spinner_button_and_wait to handle argument as either a locator or as a node * Update link sent spec to start over via cancel screen * Wait for spinner button on account page click * Remove IAL2 cancel spec from ial2_sso_spec Consolidate cancellation assertions to features/idv/cancel_spec.rb * Update Brakeman to ignore parameter value in render path Brakeman reports params used in render path. While technically true that it's referenced, it's only used in forwarding "step" parameter for URL creation, used for analytics logging Next best workaround would be to filter param with an allowlist of steps. This is simple enough, but difficult to maintain, as it would require a developer to remember to add the step to the allowlist. Without automated enforcement checks, this would be far too easy to forget. * Normalize YAML Co-authored-by: Zach Margolis <zbmargolis@gmail.com>
* update * add addiitonal required controller * required * LG-6527: prelogic kantara * LG-6527: updated prelogic for kantara req * prelogic fix * LG-6527: allow users to skip with a migration * presenter test and updated language * changelog: Upcoming Features, Authentication, add more forgiving method for authentication, * LG-6527: update timestamp, add feature tests * LG-6527: update specs * LG-6527: update spec * Lg-6527: update config to move to applciation controller * update and fix tests * remove dupe method * remove whitespace * capitalize the A * update event comment * LG-6527: default set to true * update tests
**Why**: I forgot to add it in #6549 [skip changelog]
* user registration enter email visit * Removed USER_REGISTRATION_INTRO_VISIT removed user registration intro visit since the event was removed in 2019 * user registration phone setup visited * user registration 2fa setup changelog: Internal, Analytics, Document Analytics Events
* hook up to react app first pass * update post to put, expect accepted status * Always use POST method for document capture upload Simplification enabled by new API * Update status code in spec * Include success property in document capture response * Limit arguments passed to job to required only * Reference document capture session by parameter Previous implementation would create a new DocumentCaptureSession and assign into flow_session . We reuse the one created at the start of the flow. Alternatively, consider continuing to use "verify_document_capture_session_uuid_key", but create it when the user visits document capture so it's used consistently there. * Add changelog changelog: Upcoming Features, Identity Verification, Use document capture API for async submission * Update verify document status controller specs to pass UUID Match client behavior and updated controller logic of 5ef750833 * Remove action submission event from expected events Checked that it's not referenced anywhere. We could shim this in, but since this is directly tied to FSM "actions" machinery, doesn't seem reasonable. * Update spec UUID to reference single consolidated session * Remove unnecessary step stubbing * Update verify_document_status_action_spec.rb * Add validation for document_capture_session_uuid param Previously this had been read from flow_session, now passed as a request parameter Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
* Always stub ApplicationController#analytics * Remove duplicate SSN toggle spec * Remove duplicate resolution failure spec * Call AAMVA assertions consistently and on the correct user * Consolidate content specs * Move setup behavior into test cases Avoid double-visiting, awkward "skip" exclusion which is too easy to forget * Add changelog changelog: Internal, Automated Testing, Improve automated testing performance * Add missing prep behavior
* Try eliminating IdV async polling delay in test **Why**: It could improve overall test runtime. In all cases, this polling will wait for a response to be received and handled before issuing a new request, so there should be no risk of overlapping requests overwhelming the local server. * Add changelog changelog: Internal, Automated Testing, Improve automated testing performance * Avoid skipping poll on 0 poll interval The `|| undefined` logic will be tripped for 0. The intention was to try to avoid scheduling a poll if the result of "Number" parsing was "NaN", since that would be treated the same as "0" in setTimeout, thus potentially causing a DDOS. Instead, check for finiteness of the value when scheduling.
* Move addSearchParams to dedicated file Improve package scalability * Add basic README for url package Justify the additions we're about to make as falling within the intended scope of the package by describing the package's purpose * Make sure to tear down onbeforeunload consistently Assigned in a test case, but never unassigned * Add utilities for forced redirection * Refactor existing forced redirects to use utilities * Pass additional TroubleshootingOption props to BlockLink * LG-6406: Disable "Leave site?" prompt when starting IPP **Why**: A user who chooses to verify their identity in person should not be warned about leaving the page, since they have already made the choice to leave. changelog: Upcoming Features, In-person Proofing, Remove confirmation prompt when navigating to in-person proofing * Add parameter types for forceRedirect
* Refactor address forms to use ValidatedFieldComponent * Refactor GPO verify form to use ValidatedFieldComponent * Remove unused supports for validity-specific display-if-invalid * Update IPP form to leverage formatted-fields behavior * Add changelog changelog: Internal, Code Quality, Improve consistency of form field validation * validated_form_for -> simple_form_for validated_form_for is specifically tied to form-validation JavaScript behaviors, which is what we're moving away from
* document-analytics-34 changelog: Improvements, Analytics, Updated analytics * Update app/services/vendor_status.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Update app/services/analytics_events.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * document-analytics-34 changelog: Improvements, Analytics, Updated analytics * Update app/services/analytics_events.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* IdV API: Set last GPO code for auto-fill in local development **Why**: So that a developer can complete the GPO proofing flow locally. [skip changelog] * Add feature guard for GPO code session assignment See: #6561 (comment) * Assign GPO code from form instance See: https://github.com/18F/identity-idp/pull/6561/files#r916935007 * Rename "set_" to "store_" See: https://github.com/18F/identity-idp/pull/6561/files#r916933401 Co-Authored-By: Zach Margolis <zbmargolis@gmail.com> Co-authored-by: Zach Margolis <zbmargolis@gmail.com>
* LG-6803: Revise SP context requirement to configuration **Why**: - It is more conventional to use configuration values for environment-specific behavior changes - Allows more fine-tune control in specific environments, rather than applying to all production-like environments - The logic is simpler to follow - It is easier to test locally, which is not an in-datacenter environment - It may complement upcoming work in LG-6439 for per-SP IPP access * Add changelog [skip changelog]
…6566) **Why**: Per the expected behavior in LG-5918, a user should not have to repeat entry of SSN if they choose to retake photos on the "Verify' step after a barcode attention document capture result. changelog: Improvements, Identity Verification, Skip SSN re-entry when user retakes photos after barcode attention result
**Why**: To reduce intermittent spec failures changelog: Internal, Automated Testing, Improve stability of automated tests
- SP_HANDOFF_BOUNCED_DETECTED - Document SP_HANDOFF_BOUNCED_VISIT event - Document SP_INACTIVE_VISIT event - Document BACKUP_CODE_CREATED event changelog: Internal, Analytics, Document Analytics Events
Currently this test renders this warning: ``` Checking for expected text of nil is confusing and/or pointless since it will always match. Please specify a string or regexp instead. /builds/lg/identity-idp/spec/features/idv/in_person_spec.rb:61 ``` ...and it does have a point. This commit removes the check [skip changelog]
* session kept alive * session total duration timeout * sign in page visited * sms opt-in visit sms opt-in submitted changelog: Internal, Analytics, Document Analytics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements
Internal
Upcoming Features