Skip to content

Ignore users.encrypted_phone column#6501

Merged
zachmargolis merged 1 commit intomainfrom
margolis-ignore-more-user-columns
Jun 22, 2022
Merged

Ignore users.encrypted_phone column#6501
zachmargolis merged 1 commit intomainfrom
margolis-ignore-more-user-columns

Conversation

@zachmargolis
Copy link
Contributor

Why: It's been moved to the phone_configurations table

See https://github.com/18F/identity-idp/pull/6488/files#r898215327

"do not merge" because this is a PR into #6488, so let's have that merge before trying this (to minimize merge conflicts)

@mitchellhenke mitchellhenke force-pushed the mitchellhenke/drop-unused-user-columns-4 branch 4 times, most recently from 2327a4a to 96d0d98 Compare June 21, 2022 20:30
Base automatically changed from mitchellhenke/drop-unused-user-columns-4 to main June 21, 2022 21:32
**Why**: It's been moved to the phone_configurations table

[skip changelog]
@zachmargolis zachmargolis force-pushed the margolis-ignore-more-user-columns branch from 8d91e96 to f631ad7 Compare June 21, 2022 21:37
@zachmargolis zachmargolis merged commit 2b37847 into main Jun 22, 2022
@zachmargolis zachmargolis deleted the margolis-ignore-more-user-columns branch June 22, 2022 15:42
zachmargolis added a commit that referenced this pull request Jul 5, 2022
**Why**: It was unused and normalized to the phone_configurations
table. Previously ignored in #6501

[skip changelog]
zachmargolis added a commit that referenced this pull request Jul 5, 2022
* Drop users.encrypted_phone column (ignored in #6501)
* Drop users.totp_timestamp (stopped writing in #3524)

**Why**: They were unused and normalized to the phone_configurations
and totp_configurations tables.

[skip changelog]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants