Merged
Conversation
**Why**: It was unused and normalized to the phone_configurations table. Previously ignored in #6501 [skip changelog]
mitchellhenke
approved these changes
Jul 5, 2022
app/models/user.rb
Outdated
| @@ -1,5 +1,5 @@ | |||
| class User < ApplicationRecord | |||
| self.ignored_columns = %w[encrypted_phone totp_timestamp] | |||
| self.ignored_columns = %w[totp_timestamp] | |||
Contributor
There was a problem hiding this comment.
can we also drop this 😬
Contributor
Author
There was a problem hiding this comment.
you mean drop the totp_timestamp column?
Contributor
Author
There was a problem hiding this comment.
well, I guess it's already ignored, so may as well drop it 🤷
Contributor
There was a problem hiding this comment.
Yeah, it's been ignored for...2.5 years so I think we're good 😀
theabrad
approved these changes
Jul 5, 2022
zachmargolis
added a commit
that referenced
this pull request
Jul 6, 2022
**Why**: I forgot to add it in #6549 [skip changelog]
Merged
zachmargolis
added a commit
that referenced
this pull request
Jul 6, 2022
**Why**: I forgot to add it in #6549 [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: It was unused and normalized to the phone_configurations
table. Previously ignored in #6501
[skip changelog]