Skip to content

LG-6406: Disable "Leave site?" prompt when starting IPP#6557

Merged
aduth merged 8 commits intomainfrom
aduth-lg-6406-ipp-doc-auth-prompt
Jul 8, 2022
Merged

LG-6406: Disable "Leave site?" prompt when starting IPP#6557
aduth merged 8 commits intomainfrom
aduth-lg-6406-ipp-doc-auth-prompt

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Jul 7, 2022

Why: A user who chooses to verify their identity in person should not be warned about leaving the page, since they have already made the choice to leave.

Testing Instructions:

  1. Navigate to http://localhost:3000
  2. Sign in
  3. Navigate to http://localhost:3000/verify
  4. Complete proofing flow up to document capture
  5. Submit document capture with a failing ID document
  6. Click option to proof in-person

Before: Prompted about leaving page
After: No prompt when leaving page

Screenshot:

The prompt in the following screenshot is the one being removed:

image

aduth added 7 commits July 7, 2022 13:45
Improve package scalability
Justify the additions we're about to make as falling within the intended scope of the package by describing the package's purpose
Assigned in a test case, but never unassigned
**Why**: A user who chooses to verify their identity in person should not be warned about leaving the page, since they have already made the choice to leave.

changelog: Upcoming Features, In-person Proofing, Remove confirmation prompt when navigating to in-person proofing
@aduth aduth requested a review from a team July 7, 2022 19:26
@@ -0,0 +1,16 @@
/**
Copy link
Contributor Author

@aduth aduth Jul 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a lift-and-shift from the previous index.ts (see removed lines below), apparently git/GitHub didn't pick it up as such.

Copy link
Contributor

@sheldon-b sheldon-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@aduth aduth merged commit 1e0f764 into main Jul 8, 2022
@aduth aduth deleted the aduth-lg-6406-ipp-doc-auth-prompt branch July 8, 2022 12:26
@jmdembe jmdembe mentioned this pull request Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants