Merged
Conversation
**Why**: It could improve overall test runtime. In all cases, this polling will wait for a response to be received and handled before issuing a new request, so there should be no risk of overlapping requests overwhelming the local server.
changelog: Internal, Automated Testing, Improve automated testing performance
The `|| undefined` logic will be tripped for 0. The intention was to try to avoid scheduling a poll if the result of "Number" parsing was "NaN", since that would be treated the same as "0" in setTimeout, thus potentially causing a DDOS. Instead, check for finiteness of the value when scheduling.
aduth
commented
Jul 7, 2022
| function handleResponse() { | ||
| if (response.isPending) { | ||
| if (statusPollInterval !== undefined) { | ||
| if (Number.isFinite(statusPollInterval)) { |
Contributor
Author
There was a problem hiding this comment.
More context for these changes in the extended commit description of 484665c:
The
|| undefinedlogic will be tripped for 0. The intention was to try to avoid scheduling a poll if the result of "Number" parsing was "NaN", since that would be treated the same as "0" in setTimeout, thus potentially causing a DDOS. Instead, check for finiteness of the value when scheduling.
Number.isFinite(1)
// true
Number.isFinite(0)
// true
Number.isFinite(NaN)
// false
Number.isFinite(undefined)
// false
Contributor
Author
aduth
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: To improve overall test runtime.
In all cases, this polling will wait for a response to be received and handled before issuing a new request, so there should be no risk of overlapping requests overwhelming the local server.