Do not specify origination number when sending SMS with Sender ID#6572
Merged
mitchellhenke merged 1 commit intomainfrom Jul 11, 2022
Merged
Conversation
mitchellhenke
requested review from
jmdembe,
jmhooper,
mdiarra3,
pauldoomgov and
zachmargolis
zachmargolis
approved these changes
Jul 11, 2022
lib/telephony/pinpoint/sms_sender.rb
Outdated
Contributor
There was a problem hiding this comment.
I might have used a ternary here? but same result in the end:
Suggested change
| origination_number: origination_number(country_code, sms_config, sender_id), | |
| origination_number: sender_id ? nil : origination_number(country_code, sms_config), |
Contributor
Author
There was a problem hiding this comment.
I kind of prefer keeping it all within the context of a function (though the number of parameters is approaching unwieldy)
changelog: Internal, Telephony, Do not specify origination number when sending SMS with Sender ID
mitchellhenke
force-pushed
the
mitchellhenke/sender-id-origination-numbers-for-sms
branch
from
91f840b to
5e459ce
Compare
mitchellhenke
deleted the
mitchellhenke/sender-id-origination-numbers-for-sms
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per conversations with AWS Support, specifying an origination number when using Sender ID may cause problems