Skip to content

IdV API: Set last GPO code for auto-fill in local development#6561

Merged
aduth merged 4 commits intomainfrom
aduth-verify-api-gpo-code-reveal
Jul 8, 2022
Merged

IdV API: Set last GPO code for auto-fill in local development#6561
aduth merged 4 commits intomainfrom
aduth-verify-api-gpo-code-reveal

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Jul 8, 2022

Why: So that a developer can complete the GPO proofing flow locally.

Testing Instructions:

  1. Go to http://localhost:3000
  2. Sign in
  3. Go to http://localhost:3000/verify
  4. Complete proofing flow, opting to verify address by mail at the phone step
  5. On "Come back later" screen, click Continue
  6. On account screen, click to enter the GPO code received by mail
  7. Observe there is a code pre-filled
  8. Submit the form
  9. Observe the profile is confirmed

Notes:

Referenced here:

@code = session[:last_gpo_confirmation_code] if FeatureManagement.reveal_gpo_code?

Assigned in previous flow here:

return unless FeatureManagement.reveal_gpo_code?
session[:last_gpo_confirmation_code] = idv_session.gpo_otp

**Why**: So that a developer can complete the GPO proofing flow locally.

[skip changelog]
@aduth aduth requested a review from a team July 8, 2022 13:23
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduth aduth merged commit ae19220 into main Jul 8, 2022
@aduth aduth deleted the aduth-verify-api-gpo-code-reveal branch July 8, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants