LG-5258: Allow users to start over IAL2 verification after clicking Cancel#6542
LG-5258: Allow users to start over IAL2 verification after clicking Cancel#6542
Conversation
|
Screenshots LGTM at first glance! @Kamal-Munshi I'll be OOO - would you be able to take a closer look compared to the Figma mockups, and test this out in a sandbox? Also CC @kellular if you are interested in taking a look at Andrew's implementation of the new Cancel/Start Over functionality in the remote proofing flow. Thanks y'all! |
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM, I was worried about this PR based on the number of files changed, but this looks like a straightforward rename
There was a problem hiding this comment.
😭 I forgot we had this code that parsed full HTML pages for things we didn't have an API for
There was a problem hiding this comment.
Yeah, I'd actually meant to leave a note here about this as well, since I think now after removing no-JS support for identity verification, it would be a good time to revisit these "wait" steps and have the back-end endpoint return a JSON response structured in the same way I've implemented here for this experience.
There was a problem hiding this comment.
❤️ love to see more bullet lists as arrays in i18n
There was a problem hiding this comment.
❤️ love to see more bullet lists as arrays in i18n
I was also (pleasantly) surprised to find out that _html suffixing with an array of locale strings just works, which is nice.
There was a problem hiding this comment.
WDYT of a name like click_spinner_button_and_wait?
There was a problem hiding this comment.
WDYT of a name like
click_spinner_button_and_wait?
I like that it's a bit more explicit, but not so much that it's quite verbose.
I suppose it's not entirely clear what's involved in clicking a spinner button by the name alone, so I can update this.
There was a problem hiding this comment.
Initially I wanted this to just be a plain redirect, but since this is submitted as a form, the redirect would be blocked due to CSP. Another option could be to have this be a GET request, but I think it makes sense the way it's implemented now, since it is technically a destructive action (cancelling = "destroying" the session).
aduth
force-pushed
the
aduth-lg-5258-cancel
branch
from
e41e448 to
cdd94bc
Compare
…ancel **Why**: As an end user, I expect that when I click Cancel, I will see an option to start over the identity verification process (IAL2), so that I can try to verify my identity again if I do not want to abandon the process completely. changelog: Improvements, Identity Verification, Revise cancellation screen to allow user to start over
No longer managed by the React applications, since the choice to start over is moved into the cancellation experience.
See: #6542 (comment) Co-Authored-By: Zach Margolis <zbmargolis@gmail.com>
If it turns out to be necessary to pull into viewport, might be good to have in base behavior anyways Also unsure if we still have multiple instances of "Continue" on the same screen in IdV Alternatively, update click_spinner_button_and_wait to handle argument as either a locator or as a node
aduth
force-pushed
the
aduth-lg-5258-cancel
branch
from
013add5 to
9164861
Compare
Consolidate cancellation assertions to features/idv/cancel_spec.rb
Brakeman reports params used in render path. While technically true that it's referenced, it's only used in forwarding "step" parameter for URL creation, used for analytics logging Next best workaround would be to filter param with an allowlist of steps. This is simple enough, but difficult to maintain, as it would require a developer to remember to add the step to the allowlist. Without automated enforcement checks, this would be far too easy to forget.
|
Design review in Slack: https://gsa-tts.slack.com/archives/CNCGEHG1G/p1657048158281109 |
3 participants
Why: As an end user, I expect that when I click Cancel, I will see an option to start over the identity verification process (IAL2), so that I can try to verify my identity again if I do not want to abandon the process completely.
(Review note: I may plan to split out some of this work to reduce the size of the pull request)
Screenshots: