Merged
Conversation
* Update alerts in mailers to align to match design system changelog: User-Facing Improvements, Mailers, Update alerts in mailers to align to match design system * Remove temporary debugging change
* Add test coverage for expected reCAPTCHA sign-in logging changelog: Internal, Testing, Add test coverage for expected reCAPTCHA sign-in logging * Fix typo on request controller not asserted * Add regression coverage for fix in 56378be
…FA addition. (#11029) * changelog: User-Facing Improvements, Authentication, Auth setup 2nd mfa lista all options regardless of SP * add multiple mfa sign up spec * take into accounts users who already signed in * rubocop * refactor to put in options presenter * add check for piv mfa policy
changelog: Internal, Code Quality, Remove asset tag helper patch assigning empty image alt
changelog: Internal, Code Quality, Align MfaPolicy spec filename to described class
… number" screen (#11036) changelog: User-Facing Improvements, IdV, Remove inaccurate text about being able to verify phone numbers from US territories
…ults (#11042) * make request proofing results use correct sponsor id * Changelog: User-Facing Improvements, In-person Proofing, fix usps proofer bug * make arguments and argument types consistent
* Add support for Privacy Act brochure site redirect logging changelog: Internal, Analytics, Add support for Privacy Act brochure site redirect logging * Update view spec for revised link URL
changelog: Bug Fixes, WebAuthn, Fix WebAuthn hints to pass on public key credential options
changelog: Internal, SAML implementation, Adding tests to ensure understanding around responses
* LG-13970 Log document issue year with uploads Add the year of issue of the applicant's ID to 'IdV: doc auth image upload vendor submitted' changelog: Internal,IdV logging,Added issue_year of ID
…e to reflect current Login.gov content and design system standards (#11040) * update account reset pending confirm screen * add method * remove class * fix test, correct linjk changelog: User-facing Improvements, accessibility, Add `h1` header to account reset pending screen * fix margins * fix indentation
The `DocAuthLog` model had the following columns in its ignored columns. - `email_sent_view_at` - `email_sent_view_count` - `send_link_view_at` - `send_link_view_count` These columns were dropped by a migration added in f24fb01. This commit follows up on that by removed the reference to these in the ignored columns list. [skip changelog]
This column was added to the `ignored_columns` list in 85da36e. This commit follows up on that by adding a migration to drop the column. [skip changelog]
matthinz
requested review from
a team,
eileen-nava,
jmax-gsa,
jmdembe and
mdiarra3
aduth
approved these changes
Aug 8, 2024
* Fix spec expectation of issue_year logging changelog: Internal, Automated Testing, Fix spec expectation of issue_year logging * Remove aamva ignored column * Revert "Remove aamva ignored column" This reverts commit 5e58c6f. * Ignore Rubocop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
h1header to account reset pending screen (#11040)Bug Fixes
Internal