Conversation
changelog: User-facing Improvements, accessibility, Add `h1` header to account reset pending screen
aduth
approved these changes
Aug 7, 2024
Comment on lines
+15
to
+17
| <div> | ||
| <%= link_to(t('links.go_back'), account_reset_pending_path) %> | ||
| </div> No newline at end of file |
Contributor
There was a problem hiding this comment.
Nit: Can we fix up the indentation and include a final newline?
Suggested change
| <div> | |
| <%= link_to(t('links.go_back'), account_reset_pending_path) %> | |
| </div> | |
| <div> | |
| <%= link_to(t('links.go_back'), account_reset_pending_path) %> | |
| </div> | |
Contributor
Author
There was a problem hiding this comment.
I wonder why the lint didn't catch the missing newline because it usually catches that 🤔
Contributor
There was a problem hiding this comment.
I think ERB Lint mainly lints Ruby code inside <% and %>, not HTML markup itself. Though yea, would be nice if we could find a way to enforce consistency with this. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-13870
🛠 Summary of changes
This PR adds the H1 element to the account reset cancel request confirmation form as well as a more descriptive button explaining the next step in the account reset cancellation process.
📜 Testing Plan
Pre-requisites: An existing account with at least 1 MFA method
h1element as well as the updated "Cancel request" button👀 Screenshots
Before:
After: