Skip to content

LG-13870: Update the Account deletion cancel request confirmation page to reflect current Login.gov content and design system standards#11040

Merged
jmdembe merged 6 commits intomainfrom
jd/LG-13870-update-deletion-h1
Aug 8, 2024
Merged

LG-13870: Update the Account deletion cancel request confirmation page to reflect current Login.gov content and design system standards#11040
jmdembe merged 6 commits intomainfrom
jd/LG-13870-update-deletion-h1

Conversation

@jmdembe
Copy link
Contributor

@jmdembe jmdembe commented Aug 6, 2024

🎫 Ticket

Link to the relevant ticket:
LG-13870

🛠 Summary of changes

This PR adds the H1 element to the account reset cancel request confirmation form as well as a more descriptive button explaining the next step in the account reset cancellation process.

📜 Testing Plan

Pre-requisites: An existing account with at least 1 MFA method

  • Login to your account
  • On the screen where you are prompted to authenticate, click "Choose another authentication method
  • Scroll down to the bottom of the page and click "deleting your account"
  • Continue with the deletion process by clicking "Yes, continue deletion"
  • Confirm deletion request by clicking "Yes, continue deletion"
  • Receive email stating that your account will be deleted in 24 hours
  • Return to the application and log in to your account
  • Click "Cancel request"
  • See updated screen with the new h1 element as well as the updated "Cancel request" button

👀 Screenshots

Before:
English Spanish French Chinese
screenshot of current you requested to delete your account page in english screenshot of current you requested to delete your account page in spanish screenshot of current you requested to delete your account page in french screenshot of current you requested to delete your account page in chinese
After:
English Spanish French Chinese
screenshot of updated you requested to delete your account page in english screenshot of updated you request to delete your account page in spanish screenshot of update you requested to delete your account page in french screenshot of updated you requested to delete your account page in chinese

jmdembe added 5 commits August 6, 2024 16:09
changelog: User-facing Improvements, accessibility, Add `h1` header to account reset pending screen
@jmdembe jmdembe changed the title Jd/LG-13870-update-deletion-h1 LG-13870: Update the Account deletion cancel request confirmation page to reflect current Login.gov content and design system standards Aug 7, 2024
@jmdembe jmdembe marked this pull request as ready for review August 7, 2024 17:00
@jmdembe jmdembe requested a review from a team August 7, 2024 18:02
Copy link
Contributor

@kevinsmaster5 kevinsmaster5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment on lines +15 to +17
<div>
<%= link_to(t('links.go_back'), account_reset_pending_path) %>
</div> No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Can we fix up the indentation and include a final newline?

Suggested change
<div>
<%= link_to(t('links.go_back'), account_reset_pending_path) %>
</div>
<div>
<%= link_to(t('links.go_back'), account_reset_pending_path) %>
</div>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why the lint didn't catch the missing newline because it usually catches that 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ERB Lint mainly lints Ruby code inside <% and %>, not HTML markup itself. Though yea, would be nice if we could find a way to enforce consistency with this. 👍

@jmdembe jmdembe merged commit 3596349 into main Aug 8, 2024
@jmdembe jmdembe deleted the jd/LG-13870-update-deletion-h1 branch August 8, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants