Skip to content

Remove asset tag helper patch assigning empty image alt#11044

Merged
aduth merged 1 commit intomainfrom
aduth-rm-image-alt-asset-helper-patch
Aug 7, 2024
Merged

Remove asset tag helper patch assigning empty image alt#11044
aduth merged 1 commit intomainfrom
aduth-rm-image-alt-asset-helper-patch

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Aug 7, 2024

🛠 Summary of changes

Removes a patched image_alt method defined to override Rails' default asset tag helpers, originally added in #3350.

Why?

📜 Testing Plan

Verify build passes.

changelog: Internal, Code Quality, Remove asset tag helper patch assigning empty image alt
Copy link
Contributor

@jmdembe jmdembe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the helper makes sense.

@aduth aduth merged commit 6803968 into main Aug 7, 2024
@aduth aduth deleted the aduth-rm-image-alt-asset-helper-patch branch August 7, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants