Remove asset tag helper patch assigning empty image alt#11044
Merged
Conversation
changelog: Internal, Code Quality, Remove asset tag helper patch assigning empty image alt
jmdembe
approved these changes
Aug 7, 2024
Contributor
jmdembe
left a comment
There was a problem hiding this comment.
Removing the helper makes sense.
mitchellhenke
approved these changes
Aug 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Removes a patched
image_altmethod defined to override Rails' default asset tag helpers, originally added in #3350.Why?
altattribute is a bad accessibility practice.expect_page_to_have_no_accessibility_violationsaccessibility checks are run, we should already account for absence of anyaltattributes, via Axe's "Images must have alternative text" rule📜 Testing Plan
Verify build passes.