Skip to content

LG-13725 Drop aamva column from doc_auth_logs#11052

Merged
jmhooper merged 1 commit intomainfrom
jmhooper-drop-aamva-column
Aug 8, 2024
Merged

LG-13725 Drop aamva column from doc_auth_logs#11052
jmhooper merged 1 commit intomainfrom
jmhooper-drop-aamva-column

Conversation

@jmhooper
Copy link
Contributor

@jmhooper jmhooper commented Aug 7, 2024

This column was added to the ignored_columns list in 85da36e. This commit follows up on that by adding a migration to drop the column.

This column was added to the `ignored_columns` list in 85da36e. This commit follows up on that by adding a migration to drop the column.

[skip changelog]
@jmhooper jmhooper requested review from matthinz and n1zyy August 7, 2024 20:24
Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this from ignored_columns?

And on a related note, should we go ahead and drop those other columns? I think I asked about this before, and it seemed like they should be removed.

@aduth
Copy link
Contributor

aduth commented Aug 7, 2024

@jmhooper
Copy link
Contributor Author

jmhooper commented Aug 7, 2024

The other columns were already dropped. I opened a PR to remove them from the ignored column list here: #11051

I am working on a commit to remove aamva from ignored columns which I will open in a PR with this as the base.

@aduth
Copy link
Contributor

aduth commented Aug 7, 2024

Oops, just saw your other pull request.

@aduth
Copy link
Contributor

aduth commented Aug 7, 2024

I am working on a commit to remove aamva from ignored columns which I will open in a PR with this as the base.

Is there a reason for it to be separate? I thought it was safe to remove ignored_columns entry at the same time as the database removal.

@jmhooper jmhooper merged commit b6e7326 into main Aug 8, 2024
@jmhooper jmhooper deleted the jmhooper-drop-aamva-column branch August 8, 2024 16:19
jmhooper added a commit that referenced this pull request Aug 9, 2024
The `aamva` column was dropped in #11052. This commit follows-up on that by removing it from the `ignored_columns` list on the model.

[skip changelog]
jmhooper added a commit that referenced this pull request Aug 12, 2024
The `aamva` column was dropped in #11052. This commit follows-up on that by removing it from the `ignored_columns` list on the model.

[skip changelog]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants