Align MfaPolicy spec filename to described class#11046
Merged
Conversation
changelog: Internal, Code Quality, Align MfaPolicy spec filename to described class
mitchellhenke
approved these changes
Aug 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Renames
spec/policies/user_mfa_policy_spec.rbto align to the source file it tests (app/policies/mfa_policy_spec.rb), i.e. renames tospec/policies/mfa_policy_spec.rb.This came up in #11029 (comment), where I had assumed we had no tests for this class due to the lack of an expected test file. In fact, we do have tests, but the file is named incorrectly.
Fixing this issue should help avoid similar scenarios in the future where developers may be confused about the existence of tests.
📜 Testing Plan