LG-14131: Use the correct sponsor id in request for USPS proofing results#11042
Merged
eileen-nava merged 4 commits intomainfrom Aug 7, 2024
Merged
LG-14131: Use the correct sponsor id in request for USPS proofing results#11042eileen-nava merged 4 commits intomainfrom
eileen-nava merged 4 commits intomainfrom
Conversation
eileen-nava
requested review from
a team,
KeithNava,
WilliamBirdsall,
jennyverdeyen and
zachmargolis
eileen-nava
changed the title
eileen-nava
changed the title
gina-yamada
reviewed
Aug 7, 2024
KeithNava
reviewed
Aug 7, 2024
Contributor
|
Tests in the changed spec file look all green 😄 |
Contributor
|
@eileen-nava Shane and I wanted to get this fixed up. We ran through and successfully created an EIPP enrollment and IPP enrollment. We were able to run the job successfully with the mocked USPS data. |
jennyverdeyen
approved these changes
Aug 7, 2024
Contributor
jennyverdeyen
left a comment
jennyverdeyen
left a comment
There was a problem hiding this comment.
Changes look good, tests are passing, LGTM 👍
eileen-nava
commented
Aug 7, 2024
Contributor
Author
There was a problem hiding this comment.
Thank you for fixing this!
eileen-nava
commented
Aug 7, 2024
eileen-nava
force-pushed
the
em/14131-fix-usps-proofer-bug
branch
from
fedf668 to
f297805
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-14131
🛠 Summary of changes
📜 Testing Plan