Add support for Privacy Act brochure site redirect logging#11031
Merged
Conversation
changelog: Internal, Analytics, Add support for Privacy Act brochure site redirect logging
kevinsmaster5
approved these changes
Aug 7, 2024
Contributor
kevinsmaster5
left a comment
There was a problem hiding this comment.
Looks good, tests out locally 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Supports LG-14093
🛠 Summary of changes
Adds support for the
Redirect::PolicyControllerto redirect with logging to https://login.gov/policy/our-privacy-act-statement/This is meant to help support LG-14093, which will help identify how many users may exit sign-in using one of the available brochure site links on the Sign In page. Currently, we have no logging insights to clicks on these links.
This updates the "Security Practices and Privacy Act Statement" link to use the redirect controller since support already existed for this, but does not yet update the "Privacy Act Statement" link. That link will be updated in a separate pull request to avoid issues with 50/50 deploy state.
📜 Testing Plan
make watch_eventsredirect_urlof https://www.login.gov/policy/redirect_urlof https://www.login.gov/policy/our-privacy-act-statement/