Remove request_enrollment_code method that isn't called anywhere#11049
Merged
eileen-nava merged 3 commits intomainfrom Aug 7, 2024
Merged
Remove request_enrollment_code method that isn't called anywhere#11049eileen-nava merged 3 commits intomainfrom
eileen-nava merged 3 commits intomainfrom
Conversation
zachmargolis
approved these changes
Aug 7, 2024
aduth
reviewed
Aug 7, 2024
| end | ||
|
|
||
| def self.request_enrollment_code_response | ||
| load_response_fixture('request_enrollment_code_response.json') |
Contributor
There was a problem hiding this comment.
Should the file app/services/usps_in_person_proofing/mock/responses/request_enrollment_code_response.json be removed as well?
aduth
approved these changes
Aug 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found some dead code in the usps proofer while working on PR #11042. This PR cleans up the usps proofer and associated tests.