Fix WebAuthn hints to pass on public key credential options#11050
Merged
Conversation
changelog: Bug Fixes, WebAuthn, Fix WebAuthn hints to pass on public key credential options
mitchellhenke
approved these changes
Aug 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates WebAuthn enrollment to pass the
hintsproperty on the correct nesting level of the configuration.Previously, it was passed as a property of
authenticatorSelection, but it is a sibling option ofauthenticatorSelection.Specification: https://w3c.github.io/webauthn/#sctn-parseCreationOptionsFromJSON
Related Slack discussion: https://gsa-tts.slack.com/archives/C01710KMYUB/p1723054132991659
📜 Testing Plan
If you have Chrome 128 available (currently beta, stable release planned for 8/14/24), you can verify that you are prompted for a security key when choosing to add a security key to your account. Previously, you would see a QR code prompting for a passkey, with small text mentioning the ability to use a security key.
👀 Screenshots