Merged
Conversation
[skip changelog]
* Rename route, update specs * changeloge: User-Facing Improvements, In-person proofing, Rename route for in person proofing address controller, redirect old route * fix linter error * Update route in helper method * changelog: User-Facing Improvements, In-person proofing, Rename route for in person proofing address controller
changelog: Internal, Routing, Remove temporary redirect route
* LG-11982: log with analytics. * LG-11982: test fixes. changelog: Internal, Doc Auth, Analytics for selfieAttempts. * LG-11982: test fixes. * LG-11982: start the counter from 1. * LG-11982: address some comments. * LG-11982: param need to match backend?
* create job * changelog: Upcoming Features, Auth, Migration for password compromised check * job * add query for user * test change * changelog: Upcoming Features, notify random amount of users that their password might be compromised * sessions controller * changelog: Upcoming Features, authentication, look up if user compromised * LG-12788: check password compromised * fix schema from merge conflict * address comments * deal with lint * rubocop * fix analytic event * reword migration to follow naming convention * rename to address migration change * remove question mark * update default value * reshake migration * address comments
* LG-12177: bring in changes from main. * LG-12177: add prop to event. * LG-12177: test fixes. changelog: Internal, Doc Auth, Analytics event for selfie retake.
* add get route * add controller and html file * redirect to controller view * redirect spec for address controller * add state id controller spec * lint fix * changelog: Internal, State id, add controller version of page * remove code needed for update route as not used yet * remove step info spec
**Why**: Config values change over time, but migrations should be deterministic. This old migration ran what we would now run as an explicit backfill, based on live data. Since the config that it depends on is no longer around, we can remove this block of code entirely changelog: Internal, Source code, Clean up nondeterministic migration code
* ButtonComponent: Add link_to/button_to abstraction * Update backup code regenerate form to link changelog: Bug Fixes, Regenerate Backup Codes, Fix issues linking to confirm regenerating backup codes * Refactor backup code setup regenerate using StatusPageComponent * Use subject name in specs * Fix tag_options omitting method Previously, when specifying action, many call-sites would pass `method` through tag_options, but since `method` is now a top-level constructor argument for ButtonComponent, it isn't included in tag_options. These use-cases are typically well-suited for the new abstraction, so can be updated to use it directly * Update another button with action and method * Update brakeman.ignore * Update action assigned through component slot
* Allow configuration of available locales changelog: Internal, Configuration, Allow configuration of available locales * use comma separated instead of json * add test for voice locales
* Subject reCAPTCHA checkbox assessment scores to score threshold * LG-12713: Remove reCAPTCHA checkbox fallback changelog: Internal, Spam Mitigation, Remove reCAPTCHA checkbox fallback for failed invisible assessment * Remove unused subclass methods * Add optional parameter support for first_error_message * Use parameterized first_error_message in phone flash * Replace block with inline conditional assignment See: #10454 (comment)
* Remove unused keys from `Idp::Constants::MOCK_IDV_APPLICANT` The value of `Idp::Constants::MOCK_IDV_APPLICANT` is returned from `DocAuth::Mock::ResultResponse#pii_from_doc` if no YAML file is provided. This value ultimately gets written to `pii_from_doc` in `Idv::Session`. The implementation of `DocAuth::Mock::ResultResponse#pii_from_doc` is intended to mirror the implementation of the same method on the LexisNexis TrueID client. This method does not return a hash with a `same_address_as_id`. This commit removes it so the implementation matches. The same is true of the `phone` key. That is entered by the user downstream of the state ID collection and is not returned by the LexisNexis TrueID client. There is a separate `MOCK_IDV_APPLICANT_WITH_PHONE` constant to cover cases where the phone number is needed. Finally, this commit adds `issuing_country_code` which is returned by the LexisNexis TrueID client but was not present in the hash. [skip changelog]
Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.10.60 to 1.10.61. - [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md) - [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.10.60...v1.10.61) --- updated-dependencies: - dependency-name: libphonenumber-js dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update ButtonComponent usage to use url/method abstraction changelog: Bug Fixes, Regenerate Backup Codes, Fix issues linking to confirm regenerating backup codes * Remove custom action support See: #10468 (review) * Remove additional action overrides Through subclassing and external component slot abstractions
* Pre load scripts so they are cached * changelog: User-Facing Improvements, In-person proofing, Preload selfie scripts to speed up selfie capture screen loading
* Move span into label and add aria-live * changelog: User-Facing Improvements, Document Capture, make the field error part of the label so it's read by a screen reader * Fix tests to look for label with error included * Use role="status" rather than aria-live="polite" Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com> * Revert aria/role change * Revert test changes * Revert <label> changes * Add aria-describedby function * Fix optional hint * Make selfie focus behave the same as document focus * Add tests and fix id for success message --------- Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
LG-7734: Remove SingleLogoutService from SAML metadata * Bump saml-idp version to 0.20.2-18f **Why**: - Including the SingleLogoutService endpoints with an empty Location attribute caused problems for some partners when validating the metadata **How**: - The saml_idp gem was updated to not include the SingleLogoutService endpoints in the metadata - The `include_slo_in_saml_metadata` flag was not serving any real purpose after this change and was removed changelog: User-Facing Improvements, Metadata, Remove SingleLogoutService from SAML metadata
* Clear out message and show "Photo captured" when it succeeds * changelog: User-Facing Improvements, Selfie, Change hint text update calls so user will have more relevant hint text * Revert changes
- Inlines most use cases for UpdateUser changelog: Internal, Source code, Simplify user-updating code
Contributor
aduth
approved these changes
Apr 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal
Upcoming Features