LG-12713: Remove reCAPTCHA checkbox fallback#10454
Merged
Conversation
changelog: Internal, Spam Mitigation, Remove reCAPTCHA checkbox fallback for failed invisible assessment
aduth
commented
Apr 17, 2024
Comment on lines
+271
to
+272
| recaptcha_site_key: '' | ||
| recaptcha_secret_key: '' |
Contributor
Author
There was a problem hiding this comment.
Will need to make sure this renamed configuration is in place in all deployed environments before merging.
Contributor
There was a problem hiding this comment.
IMO it would be easier to not rename the credentials
zachmargolis
approved these changes
Apr 18, 2024
Comment on lines
+271
to
+272
| recaptcha_site_key: '' | ||
| recaptcha_secret_key: '' |
Contributor
There was a problem hiding this comment.
IMO it would be easier to not rename the credentials
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-12713
🛠 Summary of changes
Removes the reCAPTCHA checkbox screen as a fallback when failing the invisible analysis, and replaces it with an error message informing the user that we cannot process their request.
📜 Testing Plan
Verify that you see an error message after submitting phone setup with a failing reCAPTCHA score:
Prerequisite: Configure score threshold in
config/application.yml:+610491570006)0.4)👀 Screenshots