LG-10790: FSM/Residential Address - Change url

[gina-yamada]

🎫 Ticket

LG-10790 FSM/Residential Address - Change url

🛠 Summary of changes

• Created new GET and PUT /in_person_/address route for IPP address controller
• Redirect GET and PUT /in_person_proofing/address route (exiting/deprecated IPP address controller) to new route
• Existing route /in_person_proofing/ was created to for the removal of the FSM address step. We'd like to rename the route to fit our existing pattern of /in_person.

📜 Testing Plan

Run the app locally. Run through all list items for each check.

Check 1:

• Complete in-person proofing up to state id step, pick No, I live at a different address, click Continue
• Verify that URL ends with /verify/in_person/address
• Complete form with a different address and submit address form
• Complete and submit ssn form
• Verify that address you typed is what appears on the Verify Info page
• Click Update for section Current residential address on the Verify Info page
• Verify that URL ends with /verify/in_person/address
• Submit address form
• Verify that address you typed is what appears on the Verify Info page
• Continue through the flow to confirm you get a barcode

Check 2:

• Complete in-person proofing up to state id step, pick same address as ID on state id form, click Continue
• Complete ad submit ssn form
• Verify that address you typed is what appears on the Verify Info page
• Click Update for section Current residential address on the Verify Info page
• Verify that URL ends with /verify/in_person/address
• Submit address form
• Verify that address you typed is what appears on the Verify Info page
• Continue through the flow to confirm you get a barcode

Check 3:

• Complete in-person proofing up to address step
• Manually change URL to /verify/in_person_proofing/address
• Check that URL gets updated to /verify/in_person/address
• (I have not been able to do this- it was suggested in Tim's PR- if you figure it out I'd love to see) Modify form to submit to /verify/in_person_proofing/address using browser inspector
• Open network tab of inspector and select "Preserve log"
• Submit address form
• Check that network tab shows the a 307 status code for the POST to /verify/in_person_proofing/address
• Check that network tab shows the a 302 status code for a subsequent POST to /verify/in_person/address
• Check that address update was successful on Verify Info page
• Continue through the flow to confirm you get a barcode

🗒️ Developer Notes

• After this PR has been merged into production, I will create a new PR to delete the deprecation notice and the redirects.
• Resource: How to Manage the 50/505 State in Handbook

🎥 Short Video

Before:

• The before video is shown on dev. You can watch the before video and confirm the following behavior.
• Notice all of the urls start with /verify/in_person/ except the address step. It starts with /verify/in_person_proofing. This was needed for removal of FSM work. Now that the address step is controller based, we want to rename the route.
• Confirm you are taken from State ID /verify/in_person/state_id to /verify/in_person_proofing/address after picking "No, I live at a different address"
• Confirm you are taken from Verify your information "/verify/in_person/verify_info" to /verify/in_person_proofing/address after clicking Update for Current residential address.

Screen.Recording.2024-04-15.at.12.35.59.PM.mov

[svalexander]

I think I found how to change the url in the inspector for check 3. This is what I did:

• Open inspector
• Go to network tab
• Click fetch/xhr tab (under filter input field)
• Right click address
• scroll down to copy and click it
• scroll to copy as fetch and click it
• click console tab
• paste in text that was just copied
• update url in this text to the url described in check 3
• update method to "POST"
• click enter
• submit form
• now there should be a log for address that has a 307 status

Stackoverflow that helped me figure the above out

[svalexander]

LGTM and works as expected