Update ButtonComponent usage to use url/method abstraction

[aduth]

🎫 Ticket

Refactoring after #10464, which supports LG-12716

🛠 Summary of changes

Updates instances of ButtonComponent action to use the new url & method shorthand introduced in #10464.

Related comment: #10464 (comment)

📜 Testing Plan

Verify no regressions in the impacted buttons.

[aduth]

One tricky thing is that button_to has an implicit method: :post, which needs to be made explicit with these updates, otherwise ButtonComponent defaults to :get. I've double-checked all of the button_to updates across this branch and #10464.

[zachmargolis]

LGTM, now I'd expect we can remove the action: keyword entirely from ButtonComponent#initialize in this PR right?

[aduth]

LGTM, now I'd expect we can remove the action: keyword entirely from ButtonComponent#initialize in this PR right?

Probably could, yeah. I don't think there's any other usage of it. It could be useful for more advanced customization, but also fair to rip it out for YAGNI.

[zachmargolis]

LGTM, now I'd expect we can remove the action: keyword entirely from ButtonComponent#initialize in this PR right?

Probably could, yeah. I don't think there's any other usage of it. It could be useful for more advanced customization, but also fair to rip it out for YAGNI.

+1 YAGNI

I think while the flexibility of it was well-intentioned, it's a really complicated API, if a new case comes along where we need additional behavior, we can cross that bridge when we get there

[aduth]

LGTM, now I'd expect we can remove the action: keyword entirely from ButtonComponent#initialize in this PR right?

Probably could, yeah. I don't think there's any other usage of it. It could be useful for more advanced customization, but also fair to rip it out for YAGNI.

+1 YAGNI

I think while the flexibility of it was well-intentioned, it's a really complicated API, if a new case comes along where we need additional behavior, we can cross that bridge when we get there

👍 Removed support in b33a4e667e.