Skip to content

Rename UpdateUser to focus on phone attributes#10479

Merged
zachmargolis merged 4 commits intomainfrom
margolis-remove-update-user
Apr 23, 2024
Merged

Rename UpdateUser to focus on phone attributes#10479
zachmargolis merged 4 commits intomainfrom
margolis-remove-update-user

Conversation

@zachmargolis
Copy link
Contributor

@zachmargolis zachmargolis commented Apr 22, 2024

  • Inlines most use cases for UpdateUser
  • Renames UpdateUser to UpdateUserPhoneConfiguration because that's where the bulk of the logic is

Possible future work: refactor UpdateUserPhoneConfiguration interface to be more specific about what side effects, such as having something like:

UpdateUserPhoneConfiguration.new(user).update_defaults(
  phone_id: ...
  otp_make_default_number: ...
)

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants