Conversation
| } | ||
| end | ||
|
|
||
| # update Idv::DocumentCaptureController.step_info.next_steps to include |
There was a problem hiding this comment.
Looking at the DocumentCaptureController it currently does not include :ipp_address as a next step. I think it should though since the address step is no longer managed by the FSM and has it's own controller, right?
There was a problem hiding this comment.
i think so, but I thought it might be something to address in the pr that adds the update route since this pr doesn't allow you to navigate past the state id page
JackRyan1989
left a comment
JackRyan1989
left a comment
There was a problem hiding this comment.
Looking great so far! Are there feature specs that will need to be updated as a result of this work?
| key: :ipp_state_id, | ||
| controller: self, | ||
| next_steps: [:ipp_address, :ipp_ssn], | ||
| preconditions: ->(idv_session:, user:) { user.establishing_in_person_enrollment }, |
There was a problem hiding this comment.
Just want to note that the before action; redirect_unless_enrollment, uses current_user whereas this precondition is using user. Is there a difference between these variables?
| pii_from_user.delete(:zipcode) | ||
| end | ||
|
|
||
| def copy_state_id_address_to_residential_address(pii_from_user) |
There was a problem hiding this comment.
Same question here, I don't think this method is being called anywhere?
| redirect_url(step) | ||
| end | ||
|
|
||
| def redirect_url(step) |
There was a problem hiding this comment.
I think this makes sense. Basically if someone is in the FSM, and we have the state_id_controller_enabled, then bump the user over to the controller based page. I think the thing that is throwing me off is that since this is the last step that's using the FSM, how would a user get into the FSM if the state id controller is enabled?
Just thinking out loud, not saying anything about removing this code.
There was a problem hiding this comment.
that's a good question. I think the InPersonController allows us to enter the fsm?
JackRyan1989
left a comment
JackRyan1989
left a comment
There was a problem hiding this comment.
Small comment about my ignorance.
JackRyan1989
left a comment
JackRyan1989
left a comment
There was a problem hiding this comment.
Manually testing looks good. Way to go!
2 participants
🎫 Ticket
Link to the relevant ticket:
LG-12375
🛠 Summary of changes
This pr adds the GET route for the the controller version of the state id page, as well as the controller, view and specs.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
Testing fsm flow
/in_person/state_id/in_person_proofing/state_idTesting controller flow
config/application.ymlfile changein_person_state_id_controller_enabledto truemake updateand thenmake run/in_person_proofing/state_id/in_person/state_idIssuing stateselect Floridaid numberIssuing stateselect Texasid numberstateselect Puerto Rico