LG-12842: More Accessible Form Errors for Document Capture#10443
Merged
LG-12842: More Accessible Form Errors for Document Capture#10443
Conversation
… error part of the label so it's read by a screen reader
charleyf
changed the title
aduth
reviewed
Apr 16, 2024
app/javascript/packages/document-capture/components/status-message.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
amirbey
approved these changes
Apr 16, 2024
Contributor
amirbey
left a comment
amirbey
left a comment
There was a problem hiding this comment.
LGTM .. i tested each photo field and the field error was focused to and read out 👍🏿
aduth
reviewed
Apr 16, 2024
app/javascript/packages/document-capture/components/file-input.tsx
Outdated
Show resolved
Hide resolved
aduth
reviewed
Apr 18, 2024
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Can we add some test coverage?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://cm-jira.usa.gov/browse/LG-12842
🛠 Summary of changes
This PR moves the field error inside the HTML
<label>for that field to make the association clearer. The ticket says that this is so that screen readers work better. The iPhone screenreader seems to work fine on both main and this branch.Note: What/when to focus is somewhat confusing and does different things depending on whether there's a red box/banner displayed on the top of the screen. See this note in Jira.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
👀 Screenshots