Remove unused keys from Idp::Constants::MOCK_IDV_APPLICANT#10470
Merged
Remove unused keys from Idp::Constants::MOCK_IDV_APPLICANT#10470
Idp::Constants::MOCK_IDV_APPLICANT#10470Conversation
The value of `Idp::Constants::MOCK_IDV_APPLICANT` is returned from `DocAuth::Mock::ResultResponse#pii_from_doc` if no YAML file is provided. This value ultimately gets written to `pii_from_doc` in `Idv::Session`. The implementation of `DocAuth::Mock::ResultResponse#pii_from_doc` is intended to mirror the implementation of the same method on the LexisNexis TrueID client. This method does not return a hash with a `same_address_as_id`. This commit removes it so the implementation matches. The same is true of the `phone` key. That is entered by the user downstream of the state ID collection and is not returned by the LexisNexis TrueID client. There is a separate `MOCK_IDV_APPLICANT_WITH_PHONE` constant to cover cases where the phone number is needed. Finally, this commit adds `issuing_country_code` which is returned by the LexisNexis TrueID client but was not present in the hash. [skip changelog]
zachmargolis
approved these changes
Apr 19, 2024
matthinz
approved these changes
Apr 19, 2024
jmhooper
deleted the
jmhooper-remove-same-address-as-id-from-idv-applicant
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value of
Idp::Constants::MOCK_IDV_APPLICANTis returned fromDocAuth::Mock::ResultResponse#pii_from_docif no YAML file is provided. This value ultimately gets written topii_from_docinIdv::Session.The implementation of
DocAuth::Mock::ResultResponse#pii_from_docis intended to mirror the implementation of the same method on the LexisNexis TrueID client. This method does not return a hash with asame_address_as_id. This commit removes it so the implementation matches.The same is true of the
phonekey. That is entered by the user downstream of the state ID collection and is not returned by the LexisNexis TrueID client. There is a separateMOCK_IDV_APPLICANT_WITH_PHONEconstant to cover cases where the phone number is needed.Finally, this commit adds
issuing_country_codewhich is returned by the LexisNexis TrueID client but was not present in the hash.