Revert Change that Didnt Fix Blackscreen#10332
Conversation
…calls so user will have more relevant hint text
| function onSelfieCaptureOpen() { | ||
| trackEvent('idv_sdk_selfie_image_capture_opened', { captureAttempts }); | ||
|
|
||
| setImageCaptureText(''); |
There was a problem hiding this comment.
I'm not actually removing this, it's just moving into the acuant-selfie-camera onOpened function
| function onSelfieCaptureClosed() { | ||
| trackEvent('idv_sdk_selfie_image_capture_closed_without_photo', { captureAttempts }); | ||
|
|
||
| setImageCaptureText(''); |
There was a problem hiding this comment.
I'm not actually removing this, it's just moving into the acuant-selfie-camera onClosed function
| }, | ||
| onPhotoTaken: () => { | ||
| // The photo has been taken and it's showing a preview with a button to accept or retake the image. | ||
| onImageCaptureFeedback(''); |
There was a problem hiding this comment.
This is getting added back, removed in the earlier PR.
|
Not sure what does following meant? @charleyf |
There was a problem hiding this comment.
Not sure what does following meant? @charleyf
It also adds an announcement (via hint text) when the selfie is captured.
@dawei-nava This is a leftover sentence that no longer reflects what I'm doing in the PR. Removed! Thanks
night-jellyfish
left a comment
night-jellyfish
left a comment
There was a problem hiding this comment.
Tested and saw the same as Dawei. Hint text is there! It is slow but I think that is the case in main right now.
charleyf
changed the title
3 participants
🛠 Summary of changes
This PR rolls back the changes here because they didn't fix the blackscreen issue.