Skip to content

LG-12177: selfie retaken log#10469

Merged
dawei-nava merged 3 commits intomainfrom
dwang/LG-12177_selfie_retaken_log
Apr 19, 2024
Merged

LG-12177: selfie retaken log#10469
dawei-nava merged 3 commits intomainfrom
dwang/LG-12177_selfie_retaken_log

Conversation

@dawei-nava
Copy link
Contributor

🎫 Ticket

Link to the relevant ticket:
LG-12177

🛠 Summary of changes

Add event idv_sdk_selfie_image_re_taken of selfie retaken

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Step 1: doc auth with selfie
  • Step 2: try capture selfie
  • Step 3: retake the selfie couple of times
  • Step 4: verify the event contains "captureAttemps" and "selfie_attempts"

Copy link
Contributor

@charleyf charleyf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logs the idv_sdk_selfie_image_re_taken event. Somewhat surprising that the selfie_attempts only gets updates when the user accepts a selfie, but I think we're doing that intentionally.

changelog: Internal, Doc Auth, Analytics event for selfie retake.
@dawei-nava dawei-nava marked this pull request as ready for review April 19, 2024 20:18
@dawei-nava dawei-nava merged commit 4286a2a into main Apr 19, 2024
@dawei-nava dawei-nava deleted the dwang/LG-12177_selfie_retaken_log branch April 19, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants