Release 2022-11-30 - (expected chart version 4.27.0)#2883
Closed
Release 2022-11-30 - (expected chart version 4.27.0)#2883
Conversation
* Fix bug in MLS user removal from conversation The list of removed clients has to be compared with those in the conversation, not the list of *all* clients of that user. * Rename getMLSClients to getClientInfo * Skip client check for deleted clients The code skipping this check was incorrectly deleted in 49782f5. This restores it (in a different form) and adds some comments explaining the logic.
Add tests for invitation urls in team invitation responses. These depend on the settings of galley.
* Add mlsSelfConvId function * Implement endpoint * Fix a typo in a test function name * Integration test: happy case * Integration test: other user attempting to join * Integration test: leaving a self-conversation * Add a changelog Co-authored-by: Marko Dimjašević <marko.dimjasevic@wire.com>
…ent data between brig and galley's clients tables. (#2830)
* Bump nixpkgs to latest unstable, stop using forked nixpkgs * Use openssl 3.0.7 for HsOpenSSL Latest nixpkgs unstable contains the fixed version of openssl. * nix/sources.json: Update description and homepage `niv update` misses this: nmattia/niv#358
* Split galley servant definition * Split galley API routes
Master->Develop after release
* Add debugtools to wire-server images * changelog * convenience makefile target for local image building
* WIP * make inputs explicit * fixup for paths * use alpine base image * Support from flokli to fix issues * formatting * add nixified nginz-disco image * attempt to add to default.nix * nginx: [warn] could not build optimal variables_hash, you should increase either variables_hash_max_size: 1024 or variables_hash_bucket_size: 64; ignoring variables_hash_bucket_size * PR feedback: openssl 1.1 * changelog * also upload nginz and nginz-disco images * PR feedback * nix/nginz.nix: add nginz to contents cannon has a preStop lifecycle hook that currently invokes nginx -c … quit on stop. * nginz container: drop exposed ports All config is defined in the helm chart, just by building the container we don't know which ports are exposed. * services/nginz: drop Dockerfile, README and Makefile We use Nix to build this now. * Hi CI * remove no-longer-necessary openssl1.1 override Co-authored-by: Florian Klink <flokli@flokli.de>
Ensure all these files are formatted.
This file is managed by niv
That list was taken from hack/bin/shellcheck.sh
…2753) * Implement global team conversations * Implemented create/retrieve for global team conv * Implemented MLS side of global team conv * Cleaned up utility function * Another missed spot from ormolu * Deleted outdated todo * Removed redundant imports, including missed spots from previous PRs. * Simplify code / feedback from review * Extracted function * Test listing conversations * Revert redundant changes now that member list is fetched. Co-authored-by: Paolo Capriotti <paolo@capriotti.io>
Add more logging and ensure that the logs are written. Apply a timeout to all calls such that firewalls and SMTP servers cannot delay SMTP connections. (There are some techniques to delay conversations with spammers forever / for a long time.) Co-authored-by: fisx <mf@zerobuzz.net>
* Create self-conversation before listing * Test: self-conversation created automatically * Create an MLS self-conversation only in v3 * Adjust tests for listing the MLS self-conversation * Drop `GET /conversations/ids` starting v3 * Make tests for `GET /conversations/ids` use v2 - The endpoint is removed starting v3, and tests by default use the latest version, which is currently v3
This reverts commit 5d9f018. It introduced flaky tests. E.g.: - https://concourse.ops.zinfra.io/teams/main/pipelines/wire-server-pr/jobs/integration-tests/builds/935.2#L634fd92d:2505 - https://concourse.ops.zinfra.io/teams/main/pipelines/wire-server-pr/jobs/integration-tests/builds/935.3#L634fda54:2468
We don't use cabal anymore to fetch packages from hackage
Co-authored-by: Zebot <zebot@users.noreply.github.com>
…2872) * Test: use a commit bundle instead of a commit * Exclude self-conversations in v2 * Test: self-conv exists and not listed below v3
…ion error. (#2862) * Improve dealing with global team convo * Re-use function instead of redefining. * Re-extracted helper conversation function * Preemptively create GTC on listing Ids * Fixed typo * Improved error type for unexpected sender client on creation for Self/GTC * Apply feedback from review.
zebot
added
the
ok-to-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[2022-11-30] (Chart Release 4.27.0)
Release notes
galley.member_clienttogalley.mls_group_member_client. When upgrading wire-server no manual steps are required. (Use MLS member table indexed by group id #2859)API changes
Support MLS self-conversations via a new endpoint
GET /conversations/mls-self. This removes thePUTcounterpart introduced in [FS-925] Add endpoint to create MLS self-conversation #2730 ([FS-925] Lazily create an MLS Self-conversation #2839)List the MLS self-conversation automatically without needing to call
GET /conversations/mls-selffirst ([FS-1191] List the MLS Self-conversation Automatically #2856)Features
PATCH#2855)Bug fixes and other updates
Avoid client deletion edge case condition which can lead to inconsistent data between brig and galley's clients tables. (Avoid client deletion edge case condition which can lead to inconsist… #2830)
Do not list MLS self-conversation in client API v1 and v2 if it exists ([FS-1249] Do Not List MLS Self-conversation in client API v1 and v2 #2872)
Prevention of storing unnecessary data in the database if adding a bot to a conversation fails. ([SQSERVICES-1801] Prevent dead bots in database #2870)
Fix bug in MLS user removal from conversation: the list of removed clients has to be compared with those in the conversation, not the list of all clients of that user (Fix client check when removing clients from MLS conversations #2817)
For sftd/coturn/restund, fixed a bug in external ip address lookup, in case Kubernetes Node Name doesn't equal hostname. ([charts:sftd,restund,coturn] Fix case when hostname is not node name #2837)
Requesting a new token with the client_id now works correctly when the old token is part of the request (Add client_id to token in all cases #2860)
Internal changes
Add tests for invitation urls in team invitation responses. These depend on the settings of galley. (Add test for urls in team invitations (SQPIT-1368) #2797)
Remove support for compiling local docker images with buildah. Nix is used to build docker images these days (remove buildah references #2822)
bump nginx-module-vts from v0.1.15 to v0.2.1 (bump nginx-module-vts from v0.1.15 to v0.2.1 #2827)
Nix-created docker images: add some debugging tools in the containers, and add 'make build-image-' for convenience (docker images: Add container utilities #2829)
Split galley API routes and handler definitions into several modules (Split galley servant definition #2820)
Default intraListing to true. This means that the list of clients, so far saved in both brig's and galley's databases, will still be written to both, but only read from brig's database. This avoids cases where these two tables go out of sync. Brig becomes the source of truth for clients. In the future, if this holds, code and data for galley's clients table can be removed. (allow configuring intra-listing in galley, make default=true #2847)
Build nginz and nginz_disco docker images using nix (Build nginz and nginz_disco docker images using nix, too #2796)
Bump nixpkgs to latest unstable. Stop using forked nixpkgs. (Bump nixpkgs to latest unstable, unpin openssl #2828)
Brig calling API is now migrated to servant ([SQSERVICES-1644] Servantify brig calling API #2815)
Fixed flaky feature TTL integration test ([SQSERVICES-1618] Flaky test for TTL feature flag #2823)
Brig teams API is now migrated to servant ([SQSERVICES-1010] Servantify brig team API #2824)
Backoffice Swagger 2.x docs is exposed on
/and the old Swagger has been removed. Backoffice helm chart only runs stern without an extra nginx. ([SQSERVICES-1787] fix backoffice swagger-ui #2846)Stern API endpoint
GET ejpd-infohas now the correct HTTP method (Fix stern API endpoint ejpd-info with correct HTTP method #2850)External commits: add additional checks (External commits: add additional checks #2852)
Golden tests for conversation and feature config event schemas ([FS-1008] Golden tests for event schemas #2861)
Refactor and simplify MLS message handling logic (Simplify and cleanup MLS message handling #2844)
Replay external backend proposals after forwarding external commits.
One column added to Galley's mls_proposal_refs. (Replay external backend proposals after external commits #2842)
Use treefmt to ensure consistent formatting of .nix files, use for shellcheck too (Use treefmt to nixpkgs-fmt all .nix files #2831)