Replay external backend proposals after external commits#2842
Merged
stefanwire merged 6 commits intodevelopfrom Nov 17, 2022
Merged
Replay external backend proposals after external commits#2842stefanwire merged 6 commits intodevelopfrom
stefanwire merged 6 commits intodevelopfrom
Conversation
zebot
added
the
ok-to-test
mdimjasevic
approved these changes
Nov 11, 2022
Contributor
mdimjasevic
left a comment
mdimjasevic
left a comment
There was a problem hiding this comment.
Overall this looks good. One thing that I'm not so sure of is if outdated backend proposals should be deleted from the database once their fresh versions are inserted into the database.
add column for origin to pending proposals table get all pending backend proposals comment on redundant calls to Brig requeue external backend proposals assert backend remove proposal in a specific epoch
stefanwire
force-pushed
the
FS-920/getBackendProposals
branch
from
97a16e2 to
6efc66b
Compare
This was referenced Nov 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/FS-920
Checklist
changelog.d