Add client_id to token in all cases#2860
Merged
pcapriotti merged 1 commit intodevelopfrom Nov 22, 2022
Merged
Conversation
Before this commit, requesting a new token with a client_id by passing the old token would not work correctly, and only result in the client_id being set in the cookie.
zebot
added
the
ok-to-test
stefanwire
approved these changes
Nov 22, 2022
This was referenced Nov 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, requesting a new token with a
client_idby passing the old token would not work correctly, and only result in theclient_idbeing set in the cookie.Checklist
changelog.d