[SQSERVICES-253] Support provisioning role information with scim PATCH#2855
Merged
battermann merged 5 commits intodevelopfrom Nov 28, 2022
Conversation
zebot
added
the
ok-to-test
battermann
changed the title
PATCH
battermann
force-pushed
the
SQSERVICES-253-feature-support-provisioning-role-information-with-scim-patch
branch
from
e6512c5 to
f4c4f88
Compare
Base automatically changed from
SQSERVICES-253-feature-support-provisioning-role-information-with-scim
to
develop
November 23, 2022 15:02
battermann
force-pushed
the
SQSERVICES-253-feature-support-provisioning-role-information-with-scim-patch
branch
2 times, most recently
from
bc357cd to
fbdaec6
Compare
battermann
force-pushed
the
SQSERVICES-253-feature-support-provisioning-role-information-with-scim-patch
branch
from
6984090 to
7455f79
Compare
fisx
approved these changes
Nov 25, 2022
Contributor
fisx
left a comment
fisx
left a comment
There was a problem hiding this comment.
looks good!
i have two nit-picks, but they can either be done in a future release or forgotten entirely.
Comment on lines
1985
to
1986
| let testWithInitialRole r = forM_ [minBound .. maxBound] (testPatchRoles brig replaceOrAdd tid owner tok r) | ||
| forM_ [minBound .. maxBound] testWithInitialRole |
Contributor
There was a problem hiding this comment.
i suggested a different way to write this, but this time i have another suggestion :-)
Suggested change
| let testWithInitialRole r = forM_ [minBound .. maxBound] (testPatchRoles brig replaceOrAdd tid owner tok r) | |
| forM_ [minBound .. maxBound] testWithInitialRole | |
| let values = [[], ["member", "admin"], ["notarole"]] <> (:[]) <$> [minBound .. maxBound] | |
| testWithInitialRole r = forM_ values (testPatchRoles brig replaceOrAdd tid owner tok r) | |
| forM_ values testWithInitialRole |
(this would require to take [Role] instead of Role in initial and target below.)
Contributor
There was a problem hiding this comment.
maybe this trick could also be used to simplify the tests for POST, PUT?
Contributor
Author
There was a problem hiding this comment.
i suggested a different way to write this, but this time i have another suggestion :-)
I know, but that didn't compile, and I tried to come as close as possible.
battermann
deleted the
SQSERVICES-253-feature-support-provisioning-role-information-with-scim-patch
branch
This was referenced Nov 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/SQSERVICES-253
support for
PATCHChecklist
changelog.d