Fix client check when removing clients from MLS conversations#2817
Merged
pcapriotti merged 4 commits intodevelopfrom Nov 3, 2022
Merged
Fix client check when removing clients from MLS conversations#2817pcapriotti merged 4 commits intodevelopfrom
pcapriotti merged 4 commits intodevelopfrom
Conversation
The list of removed clients has to be compared with those in the conversation, not the list of *all* clients of that user.
zebot
added
the
ok-to-test
stefanwire
approved these changes
Nov 2, 2022
smatting
approved these changes
Nov 3, 2022
The code skipping this check was incorrectly deleted in 49782f5. This restores it (in a different form) and adds some comments explaining the logic.
pcapriotti
force-pushed
the
pcapriotti/mls-removal-bug
branch
from
00c8e8c to
48047b4
Compare
This was referenced Nov 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d