docker images: Add container utilities#2829
Merged
Conversation
zebot
added
the
ok-to-test
flokli
reviewed
Nov 7, 2022
Contributor
flokli
left a comment
flokli
left a comment
There was a problem hiding this comment.
It's very hard to see what this PR is actually changing. Can you move the code formatting into a separate commit?
Member
Author
sorry I can't easily, as my editor now reformats nix code. Perhaps we should include a formatter for nix code in wire-server, and reformat all nix code once, to not have this issue going forward. But you can tick "Hide Whitespace" here:
|
jschaul
force-pushed
the
container-utilities
branch
from
132c1bd to
cab2a6e
Compare
jschaul
force-pushed
the
container-utilities
branch
from
cab2a6e to
87b769e
Compare
Member
Author
|
Rebased, no reformatting anymore. |
Contributor
|
Check #2831, which ensures .nix code is consistently formatted. |
flokli
approved these changes
Nov 8, 2022
This was referenced Nov 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d