[charts:sftd,restund,coturn] Fix case when hostname is not node name#2837
Merged
sysvinit merged 2 commits intowireapp:developfrom Nov 14, 2022
Merged
Conversation
Kubernetes might be installed in a way where the machine hostname is not used as node name. Using the statefulset's spec to determine the node name would allow for such deviation.
flokli
approved these changes
Nov 9, 2022
Contributor
flokli
left a comment
flokli
left a comment
There was a problem hiding this comment.
LGTM. I added a small changelog entry.
sysvinit
approved these changes
Nov 9, 2022
akshaymankar
added
the
ok-to-test
Contributor
Contributor
|
I think @sysvinit wanted to still test this? |
Contributor
|
No, I just forgot to hit merge. |
This was referenced Nov 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kubernetes might be installed in a way where the machine hostname is not used as node name. Using the statefulset's spec to determine the node name would allow for such deviation.
Checklist
changelog.d