Skip to content

Comments

[FS-925] Add endpoint to create MLS self-conversation#2730

Merged
mdimjasevic merged 8 commits intodevelopfrom
FS-925-mls-self
Nov 7, 2022
Merged

[FS-925] Add endpoint to create MLS self-conversation#2730
mdimjasevic merged 8 commits intodevelopfrom
FS-925-mls-self

Conversation

@smatting
Copy link
Contributor

@smatting smatting commented Sep 27, 2022

The PR introduces a new endpoint PUT /conversations/mls-self for creating and retrieving an MLS self-conversation.

Tracked by https://wearezeta.atlassian.net/browse/FS-925.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@smatting smatting temporarily deployed to cachix September 27, 2022 16:41 Inactive
@smatting smatting temporarily deployed to cachix September 27, 2022 16:41 Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Sep 27, 2022
@mdimjasevic mdimjasevic changed the title Add endpoint to retrieve MLS self-conversation [FS-925] Add endpoint to retrieve MLS self-conversation Sep 28, 2022
@mdimjasevic mdimjasevic temporarily deployed to cachix September 28, 2022 07:08 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix September 28, 2022 07:08 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix October 5, 2022 10:42 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix October 5, 2022 10:42 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix October 28, 2022 07:26 Inactive
@smatting smatting temporarily deployed to cachix October 31, 2022 18:02 Inactive
@smatting smatting temporarily deployed to cachix October 31, 2022 18:02 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix November 3, 2022 12:54 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix November 3, 2022 14:11 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix November 3, 2022 14:19 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix November 3, 2022 14:26 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix November 4, 2022 09:28 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix November 4, 2022 09:37 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix November 4, 2022 13:55 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix November 4, 2022 14:01 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix November 4, 2022 14:02 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix November 4, 2022 14:03 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix November 4, 2022 14:50 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix November 4, 2022 15:08 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix November 4, 2022 15:15 Inactive
@mdimjasevic mdimjasevic changed the title [FS-925] Add endpoint to retrieve MLS self-conversation [FS-925] Add endpoint to create MLS self-conversation Nov 4, 2022
@mdimjasevic mdimjasevic temporarily deployed to cachix November 4, 2022 15:29 Inactive
@mdimjasevic mdimjasevic marked this pull request as ready for review November 4, 2022 15:29
ncProtocol = ProtocolMLSTag
}
conv <- E.createConversation lcnv nc
-- TODO: remove this. we are planning to remove the need for a nullKeyPackageRef
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FUTUREWORK?

Copy link
Contributor

@mdimjasevic mdimjasevic Nov 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smatting , you've added this. Should we make it a FUTUREWORK note? I assume that's fine with you so I "promoted" the note, which should make the PR ready for merging. In case you disagree, there's more work to do anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants