Simplify and cleanup MLS message handling#2844
Merged
pcapriotti merged 7 commits intodevelopfrom Nov 15, 2022
Merged
Conversation
zebot
added
the
ok-to-test
2 tasks
mdimjasevic
approved these changes
Nov 15, 2022
Contributor
mdimjasevic
left a comment
mdimjasevic
left a comment
There was a problem hiding this comment.
@pcapriotti , it all looks good except that I am not too sure of that group info storing before checks. If you confirm it is fine this way, feel free to merge.
smatting
approved these changes
Nov 15, 2022
This was referenced Nov 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to simplify and streamline the logic of MLS message handling. There is still a lot of complexity there, but hopefully less than before. This PR also introduces optional Client IDs taken from the tokens into the MLS message handlers. Making those IDs mandatory and changing conversation creation logic in the V3 API will happen in a separate PR.
Checklist
changelog.d