The Original Hermes Repository changes #25
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from 4.2.1 to 4.2.4. - [Release notes](https://github.com/socketio/socket.io-parser/releases) - [Changelog](https://github.com/socketio/socket.io-parser/blob/main/CHANGELOG.md) - [Commits](socketio/socket.io-parser@4.2.1...4.2.4) --- updated-dependencies: - dependency-name: socket.io-parser dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Start of expanded ProductAreasService * Remove unused functions and classes * Update tests * Test abbreviation logic change * Test cleanup * Fix failing tests * Add fetch call to ProductSelect * Fetch product areas in the background
* Fix owner photo bug for v2 drafts API * Make the documents API consistent for owner photo search logic * 404 on document draft attempting to be accessed via the documents API
* Tweak HDS types * Updates `get-product-id` files * Add `medium` size to DocThumbnail * Remove number type * Update `productShortName` getter * Avatar.gts * Basic ProductAvatar implementation * Add `large` size to PersonAvatar * Refactor to class-based sizing * Fix visual bugs, rename SCSS file * Refactor Thumbnail interface * Switch `size` to getters * Remove unused getters * Fix merge conflict * Update thumbnail.ts * Remove unnecessary property * Refactor sizes * Use enum in folder-affordance * Revert css changes * Additional cleanup
* Say "Me" if it's me * Add test helper
* Table improvements * Revert some changes * Style tweaks * Helper and utility tests * Add alpha color * Update product-badge.scss
* Add ProjectIndex and Resource components * Add `large` size to PersonAvatar * Project index files * Remove `pauseTest` * Renames and types for added clarity * Cleanup and documentation * Post-meeting endpoint tweaks * Basic "clear type errors" commit * Mark todos; cleanup Mirage config * Add JiraIssue and HermesDocument * Cleanup * Fix v1 reference and related-resource URL * Update config.ts * jiraObject → jiraIssue * Updates add/remove project resource methods * Renames * Renames * Update property name
* Add z-index to header * Fix animated tools
Add chevron to toggleAction
* Edit "time-ago" function * Make limiting optional
* Update authenticated-user.ts * Add another typo
* Improve document error redirect * Remove potentially confusing line
Fix draft links
* Don't error when updating recently viewed docs if a doc is not found * Log errors instead of warnings now when failing to update recently viewed docs * Log non-record-not-found errors as errors
* Standardize flashMessages * Standardize long time
Table cleanup
Unify default mock date
Update error-404.scss
Replace test strings with variables
* Set up Transfer modal * Set up TypeToConfirm * Improve design * Improve error handling * Tweak TypeToConfirm value * Write and stub tests * Update base.d.ts * Update sidebar.ts * Write type-to-confirm tests * Add PeopleSelect tests * Enable patching a document's owner * Tweak grammar * Fix transferOwnership payload * Update sidebar.ts * Start of modal success * Add `document` assertions * Fix failing/stubbed tests * Switch `owners` syntax * Cleanup and documentation * Update sidebar.ts * Update document-test.ts * Allow drafts to be transferred --------- Co-authored-by: Josh Freda <[email protected]>
Register a couple `application` components
Handle errors in Recently Viewed
* Improve modalAlert * Refactor `setActive` * Handle errors in Recently Viewed * Update modal-alerts-test.ts * Convert Modals to `gts` * Add redirect test * Rename attributes and add documentation * Tweak grammar
* Update package.json * Update Node version in README.md
* Add EmberData support to JiraIssues * Remove`fade-in` animation * Update types and descriptions
Fix store types
Update config.ts
…dal (#656) Update approvers in sidebar
* Remove background fetches * Update project-test.ts
* Start of static filters * Update documents.ts * Dynamic filters (non-owner) * Design tweaks, start of new Facet methods * Smaller input * Add headline to filtered docs * Tweak input size * Revert `getFacets` changes * Hook up owner search * Improved dropdown/input design * Exclude existing owners * Redesign `count` * `is-active-filter` test * Remove unnecessary args * Update existing tests * Add fallback value to `dd.LinkTo` component * Standardize input width * Add documentation * Update tests * Add owner search test * Add results test * Cleanup * Also search Google People API
Update toolbar.hbs
* Improve focus styles on Doc::TileMedium * Empty-Commit
Refactor some CSS
* WIP prototype * WIP Prototype * WIP Prototype (edge detection) * WIP index logic * WIP index logic * Save reorder on drop * Cleanup * Rearrange with custom preview * Start of dropdown list * WIP smart configuration * Make drag setup dynamic * Add moveUp/moveDown args to external links * Small readOnly/itemsLength refactor * Add icons to "move" menu * Add dropdown menu functions * Fix `toBottom` action; tweak menu item padding * Improved drag affordances * Improve hover / focus states * Remove comment * Remove unused getter * Remove out-of-scope prettier changes * Cleanup reorder function; add documentation * Add documentation * Remove `id` artifacts * Close dropdown when dragging * Announce movement onDrop * CSS tweaks * Refactor some CSS * Add `TileMedium` test * CSS cleanup * Add `resource-test` * Test icons * Add drag-handle test * Test rearranging docs * Test reordering links * Fix externalLink test * Don't allow lists to drag/drop into each other * Refactor `isHoveringSameParent` * Focuses dragHandle after drop
* Use backend for project-status filtering * Start of param-based page request * Cleanup * Update projects GET response to include page and total number of pages * Add pagination to projects * Update mirage and `addToOrCreate` --------- Co-authored-by: Josh Freda <[email protected]>
* Remove approvers from drafts POST request - this isn't used in the frontend * Add groups API * Support group approvals * Forgot document group review model * Add members of approver groups as individual approvers in the database * Enable setting a Google Groups prefix * Only apply prefix if it looks like the user isn't beginning to type it * Return results with and without a configured groups prefix
…#671) Reset page when clicking segmented tab
* Prep for groups in the PeopleSelect * Explore XDropdownList * More basicDropdown discovery * Improve types and styles * Update nav.hbs * Add offset, improve styles * Improve dropdown design * Style tweak * WIP "Loading" * Improve loading states * Cleanup * Update people-select-test.ts * Tweak styles and offset * Prevent dropdown from opening on ArrowUp/Down * Set up `includeGroups` arg * Revert unnecessary change * Flatten array instead of groups * Reduce diff * Start of EmberData files * Clean Mirage People route * More prep for EmberData requests * Add notes from meeting with Josh * Rename/reorganize * Post-merge resolutions * Add conditional approve button and text * Improve group handling * Add group logic to maybeFetchPeople * Track cachedValue in `editableField` * Fix test; WIP update-editable-field function * Put TODO catch block on OPTIONS call * Get list to update on groupApproverClick * Remove approvers from drafts POST request - this isn't used in the frontend * Add groups API * Support group approvals * Forgot document group review model * WIP OPTIONS call * Add members of approver groups as individual approvers in the database * Load group with `maybeFetchPeople` * Filter departed users * Fix errors * Add/update tests; cleanup and documentation * Enable setting a Google Groups prefix * Only apply prefix if it looks like the user isn't beginning to type it * Add "remove me" assertion * Return results with and without a configured groups prefix --------- Co-authored-by: Josh Freda <[email protected]>
* Update sidebar.hbs * Update document-test.ts * Cleanup * Update document-test.ts
* Update group approvals config format * Update docs to account for group approvals * Add property to Config; update API * Make approver groups conditional * Add dashboard announcement * Make Group callout conditional * Update groups API * Remove commented-out code --------- Co-authored-by: Jeff Daley <[email protected]>
Remove console logs
Cleanup and documentation
Improve markup and typography on Publish modal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes done by
HashiCorpto enhance Hermes frontend and User Interaction.Thanks