Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search owner facet #659

Merged
merged 26 commits into from
Mar 28, 2024
Merged

Search owner facet #659

merged 26 commits into from
Mar 28, 2024

Conversation

jeffdaley
Copy link
Contributor

@jeffdaley jeffdaley commented Mar 25, 2024 •
edited
Loading

Replaces the "Owner" dropdown with a search input. Now all owners are filterable, not just the top 100, and not just by email address (we now search the Google People API in addition to Algolia).

CleanShot 2024-03-25 at 11 24 18@2x
  • Also adds a match count to the /documents route consistent with the results?scope=documents screen.
  • Alphabetizes the dropdown lists and de-emphasizes the (often incorrect) count

@jeffdaley
Start of static filters
4dbe7a2
@jeffdaley
Update documents.ts
d2f891e
@jeffdaley
Dynamic filters (non-owner)
55e1879
@jeffdaley
Design tweaks, start of new Facet methods
3d93b49
@jeffdaley
Smaller input
f90e18d
@jeffdaley
Add headline to filtered docs
15e951c
@jeffdaley
Merge branch 'jeffdaley/filtered-results-headline' into jeffdaley/sta…
090b7dd 
…tic-facets
@jeffdaley
Tweak input size
bb99437
@jeffdaley
Revert getFacets changes
bdb1a95
@jeffdaley
Hook up owner search
e635a9f
@jeffdaley
Improved dropdown/input design
45c369a
@jeffdaley
Exclude existing owners
5c959da
@jeffdaley
Redesign count
003cc25
@jeffdaley
is-active-filter test
151976f
@jeffdaley
Remove unnecessary args
a2fcd7a
@jeffdaley
Update existing tests
cf70f94
@jeffdaley
Add fallback value to dd.LinkTo component
0a971c3
@jeffdaley
Merge branch 'jeffdaley/link-to' into jeffdaley/static-facets
3a9939a
@jeffdaley
Standardize input width
a2af5df
@jeffdaley
Merge branch 'main' into jeffdaley/static-facets
67a0f56
@jeffdaley
Add documentation
2905c48
@jeffdaley
Update tests
840534b
@jeffdaley
Add owner search test
b5c6b25
@jeffdaley
Add results test
acf69ee
@jeffdaley
Cleanup
42c6d51
@jeffdaley jeffdaley marked this pull request as ready for review March 25, 2024 15:28
@jeffdaley jeffdaley requested a review from a team as a code owner March 25, 2024 15:28
@jeffdaley jeffdaley marked this pull request as draft March 25, 2024 16:37
@jeffdaley jeffdaley marked this pull request as ready for review March 25, 2024 18:27
jfreda
jfreda approved these changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@jfreda jfreda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jeffdaley jeffdaley merged commit 40c87d5 into main Mar 28, 2024
1 check passed
@jeffdaley jeffdaley deleted the jeffdaley/static-facets branch March 28, 2024 22:19
@jeffdaley jeffdaley added the enhancement New feature or request label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfreda jfreda jfreda approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffdaley @jfreda