Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix StoreService types #653

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Fix StoreService types #653

merged 1 commit into from
Mar 18, 2024

Conversation

jeffdaley
Copy link
Contributor

Fixes a warning related to our extended StoreService.

WARNING: Detected collisions between .js and .ts files of the same name. This can result in nondeterministic build output; see https://git.io/JvIwo for more information.

  • hermes/services/store.{js,ts}

This follows the same pattern as the SessionService

@jeffdaley jeffdaley marked this pull request as ready for review March 18, 2024 19:36
@jeffdaley jeffdaley requested a review from a team as a code owner March 18, 2024 19:36
@jeffdaley jeffdaley merged commit 3f52210 into main Mar 18, 2024
1 check passed
@jeffdaley jeffdaley deleted the jeffdaley/store-service branch March 18, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfreda jfreda jfreda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffdaley @jfreda