Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace test strings with shared variables #440

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Replace test strings with shared variables #440

merged 1 commit into from
Nov 21, 2023

Conversation

jeffdaley
Copy link
Contributor

@jeffdaley jeffdaley commented Nov 21, 2023 •
edited
Loading

  • Replaces instances of [email protected] (the default Mirage user) with a shared variable TEST_USER_EMAIL
  • Does the same for a few other common test attributes

@jeffdaley jeffdaley changed the title Replace test strings with variables Replace test strings with shared variables Nov 21, 2023
@jeffdaley jeffdaley marked this pull request as ready for review November 21, 2023 16:27
@jeffdaley jeffdaley requested a review from a team as a code owner November 21, 2023 16:27
@jeffdaley jeffdaley merged commit 07414cb into main Nov 21, 2023
2 checks passed
@jeffdaley jeffdaley deleted the jeffdaley/test-user-vars branch November 21, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfreda jfreda jfreda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffdaley @jfreda