Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make group approvals conditional based on config #674

Merged
merged 8 commits into from
Apr 12, 2024

Conversation

jfreda
Copy link
Collaborator

@jfreda jfreda commented Apr 11, 2024

This PR makes group approvals conditional on a new config option.

Breaking changes - config.hcl

Previously (from #660):

google_workspace {
  ...
  // groups_prefix is the prefix to use when searching for Google Groups.
  groups_prefix = "team-"
  ...
}

Now:

google_workspace {
  ...
  // group_approvals is the configuration for using Google Groups as document
  // approvers.
  group_approvals {
    // enabled enables using Google Groups as document approvers.
    enabled = true

    // search_prefix is the prefix to use when searching for Google Groups.
    search_prefix = "team-"
  }
  ...
}

@jfreda jfreda added the breaking changes PR contains breaking changes label Apr 11, 2024
@jeffdaley jeffdaley marked this pull request as ready for review April 12, 2024 13:56
@jeffdaley jeffdaley requested a review from a team as a code owner April 12, 2024 13:56
@jfreda jfreda merged commit 52bbe69 into main Apr 12, 2024
2 checks passed
@jfreda jfreda deleted the conditional-group-approvals branch April 12, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking changes PR contains breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants