Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize FlashMessage properties #426

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Conversation

jeffdaley
Copy link
Contributor

Adds default configurations for the FlashMessage service as well as critical() and success() helper methods. Standardizes the duration of long timeouts. We'll now import from an extended service (HermesFlashMessagesService) which includes types for the new utility methods.

@jeffdaley jeffdaley marked this pull request as ready for review November 15, 2023 18:48
@jeffdaley jeffdaley requested a review from a team as a code owner November 15, 2023 18:48
@jeffdaley jeffdaley merged commit 92f34d2 into main Nov 17, 2023
2 checks passed
@jeffdaley jeffdaley deleted the jeffdaley/document-errors branch November 17, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants