Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add projects to FlagsService; add conditional Projects navLink #434

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Add projects to FlagsService; add conditional Projects navLink #434

merged 3 commits into from
Nov 21, 2023

Conversation

jeffdaley
Copy link
Contributor

@jeffdaley jeffdaley commented Nov 17, 2023 •
edited
Loading

  • Adds projects getter to the FlagsService
  • Converts FlagsService to TS
  • Adds version and short_revision to the HermesConfig type definition
  • Adds Projects nav link if flag is enabled

@jeffdaley jeffdaley changed the title Add projects to FlagsService Add projects to FlagsService; add conditional Projects navLink Nov 17, 2023
@jeffdaley jeffdaley marked this pull request as ready for review November 17, 2023 02:16
@jeffdaley jeffdaley requested a review from a team as a code owner November 17, 2023 02:16
@jeffdaley jeffdaley merged commit 27196b7 into main Nov 21, 2023
2 checks passed
@jeffdaley jeffdaley deleted the jeffdaley/feature-flags branch November 21, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfreda jfreda jfreda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffdaley @jfreda