Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support group approvals #660

Merged
merged 8 commits into from
Apr 4, 2024
Merged

Support group approvals #660

merged 8 commits into from
Apr 4, 2024

Conversation

jfreda
Copy link
Collaborator

@jfreda jfreda commented Mar 26, 2024

This PR adds support for Google Group approvers. Google Groups will be listed as approvers first in the document header, followed by individual approvers. When a member of a Google Group approver approves the document, they will be added as an individual approver.

Breaking changes

  • The Admin SDK API must be enabled in Google Workspace (this is required to query Google Groups)
  • New https://www.googleapis.com/auth/admin.directory.group.readonly scope is required

New (optional) config

google_workspace {
  ...
  // groups_prefix is the prefix to use when searching for Google Groups.
  groups_prefix = "team-"
  ...
}

New APIs

  • /groups: searches Google Groups by prefix
    • Method: POST
    • Params: query

Modified APIs

  • /approvals/{document_id}
    • Added method: OPTIONS

@jfreda jfreda added enhancement New feature or request breaking changes PR contains breaking changes labels Mar 26, 2024
@jfreda jfreda requested a review from a team as a code owner March 26, 2024 23:54
@jfreda jfreda merged commit 3b0597d into main Apr 4, 2024
2 checks passed
@jfreda jfreda deleted the jfreda/support-group-approvals branch April 4, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking changes PR contains breaking changes enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants