Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table and ProductLink design changes #418

Merged
merged 6 commits into from
Nov 14, 2023
Merged

Table and ProductLink design changes #418

merged 6 commits into from
Nov 14, 2023

Conversation

jeffdaley
Copy link
Contributor

@jeffdaley jeffdaley commented Nov 9, 2023 •
edited
Loading

  • ProductBadgeLink → ProductLink - component can now yield a non-badge link
  • RowResults → Documents::Table
  • Adds hover effect to the table rows
  • Increases click areas for the primary table link
  • Improves focus states when keyboard navigating
  • Adds getProductLabel helpers to return "Unknown" or "HCP" under certain conditions
  • Sticky table header
  • Spacing tweaks

@jeffdaley jeffdaley changed the title Table improvements Table and ProductLink improvements Nov 10, 2023
@jeffdaley jeffdaley changed the title Table and ProductLink improvements Table and ProductLink design changes Nov 10, 2023
@jeffdaley jeffdaley marked this pull request as ready for review November 10, 2023 02:24
@jeffdaley jeffdaley requested a review from a team as a code owner November 10, 2023 02:24
@jeffdaley jeffdaley merged commit 37592d5 into main Nov 14, 2023
2 checks passed
@jeffdaley jeffdaley deleted the jeffdaley/tables branch November 14, 2023 14:19
This was referenced Nov 14, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfreda jfreda jfreda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffdaley @jfreda