refactor(ast): estree via on struct fields implement From#8898
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 5, 2025
Merged
Conversation
This was referenced Feb 4, 2025
Member
Author
CodSpeed Performance ReportMerging #8898 will not alter performanceComparing Summary
|
This was referenced Feb 4, 2025
d4eb7a7 to
5046b09
Compare
80264d4 to
74d5176
Compare
Contributor
Merge activity
|
5046b09 to
223eb8d
Compare
Base automatically changed from
02-04-refactor_ast_override_ts_type_defs_with_estree_custom_ts_def_attribute_on_type
to
main
February 4, 2025 23:13
74d5176 to
f22d18b
Compare
Align the behavior of custom serialization to ESTree using the `#[estree(via)]` attribute. Change its behavior on struct fields to match structs - the "via" type must implement `From` to convert from the original type to itself. The future goal is to use these same "via" types to go back in the other direction (JS -> Rust), so we need to have a casting system.
f22d18b to
5cb8466
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Align the behavior of custom serialization to ESTree using the
#[estree(via)]attribute. Change its behavior on struct fields to match structs - the "via" type must implementFromto convert from the original type to itself.The future goal is to use these same "via" types to go back in the other direction (JS -> Rust), so we need to have a casting system.