feat(ast_tools): generate mapping of trait name to crate in oxc_ast_macros#8870
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 4, 2025
Conversation
This was referenced Feb 3, 2025
Member
Author
This was referenced Feb 3, 2025
CodSpeed Performance ReportMerging #8870 will not alter performanceComparing Summary
|
d11853d to
64c913b
Compare
f0fb048 to
d11733c
Compare
This was referenced Feb 3, 2025
64c913b to
344d6e1
Compare
d11733c to
2f55d91
Compare
This was referenced Feb 3, 2025
344d6e1 to
435aca3
Compare
2f55d91 to
92fcb66
Compare
Contributor
Merge activity
|
…macros` (#8870) `oxc_ast_macros` contains a function which takes the name of a trait, and returns the crate that trait is defined in. Instead of having that info hard-coded in 2 places, codify it in generator for that trait in `oxc_ast_tools`, and codegen this function in `oxc_ast_macros` instead.
435aca3 to
b7ff7e1
Compare
92fcb66 to
8f0b865
Compare
Base automatically changed from
02-03-refactor_span_export_contenteq_trait_from_root_of_oxc_span_crate
to
main
February 4, 2025 03:33
This was referenced Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

oxc_ast_macroscontains a function which takes the name of a trait, and returns the crate that trait is defined in.Instead of having that info hard-coded in 2 places, codify it in generator for that trait in
oxc_ast_tools, and codegen this function inoxc_ast_macrosinstead.