Skip to content

feat(ast_tools): generate mapping of trait name to crate in oxc_ast_macros#8870

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-03-feat_ast_tools_generate_mapping_of_trait_name_to_crate_in_oxc_ast_macros_
Feb 4, 2025
Merged

feat(ast_tools): generate mapping of trait name to crate in oxc_ast_macros#8870
graphite-app[bot] merged 1 commit intomainfrom
02-03-feat_ast_tools_generate_mapping_of_trait_name_to_crate_in_oxc_ast_macros_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Feb 3, 2025

oxc_ast_macros contains a function which takes the name of a trait, and returns the crate that trait is defined in.

Instead of having that info hard-coded in 2 places, codify it in generator for that trait in oxc_ast_tools, and codegen this function in oxc_ast_macros instead.

Copy link
Member Author

overlookmotel commented Feb 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 3, 2025

CodSpeed Performance Report

Merging #8870 will not alter performance

Comparing 02-03-feat_ast_tools_generate_mapping_of_trait_name_to_crate_in_oxc_ast_macros_ (8f0b865) with 02-03-refactor_span_export_contenteq_trait_from_root_of_oxc_span_crate (b7ff7e1)

Summary

✅ 33 untouched benchmarks

@overlookmotel overlookmotel marked this pull request as ready for review February 3, 2025 16:31
@overlookmotel overlookmotel force-pushed the 02-03-refactor_span_export_contenteq_trait_from_root_of_oxc_span_crate branch from d11853d to 64c913b Compare February 3, 2025 18:52
@overlookmotel overlookmotel force-pushed the 02-03-feat_ast_tools_generate_mapping_of_trait_name_to_crate_in_oxc_ast_macros_ branch from f0fb048 to d11733c Compare February 3, 2025 18:52
@overlookmotel overlookmotel force-pushed the 02-03-refactor_span_export_contenteq_trait_from_root_of_oxc_span_crate branch from 64c913b to 344d6e1 Compare February 3, 2025 20:22
@overlookmotel overlookmotel force-pushed the 02-03-feat_ast_tools_generate_mapping_of_trait_name_to_crate_in_oxc_ast_macros_ branch from d11733c to 2f55d91 Compare February 3, 2025 20:22
@overlookmotel overlookmotel force-pushed the 02-03-refactor_span_export_contenteq_trait_from_root_of_oxc_span_crate branch from 344d6e1 to 435aca3 Compare February 3, 2025 21:55
@overlookmotel overlookmotel force-pushed the 02-03-feat_ast_tools_generate_mapping_of_trait_name_to_crate_in_oxc_ast_macros_ branch from 2f55d91 to 92fcb66 Compare February 3, 2025 21:55
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Feb 4, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 4, 2025

Merge activity

…macros` (#8870)

`oxc_ast_macros` contains a function which takes the name of a trait, and returns the crate that trait is defined in.

Instead of having that info hard-coded in 2 places, codify it in generator for that trait in `oxc_ast_tools`, and codegen this function in `oxc_ast_macros` instead.
@graphite-app graphite-app bot force-pushed the 02-03-refactor_span_export_contenteq_trait_from_root_of_oxc_span_crate branch from 435aca3 to b7ff7e1 Compare February 4, 2025 02:51
@graphite-app graphite-app bot force-pushed the 02-03-feat_ast_tools_generate_mapping_of_trait_name_to_crate_in_oxc_ast_macros_ branch from 92fcb66 to 8f0b865 Compare February 4, 2025 02:51
Base automatically changed from 02-03-refactor_span_export_contenteq_trait_from_root_of_oxc_span_crate to main February 4, 2025 03:33
@graphite-app graphite-app bot merged commit 8f0b865 into main Feb 4, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 02-03-feat_ast_tools_generate_mapping_of_trait_name_to_crate_in_oxc_ast_macros_ branch February 4, 2025 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast-tools Area - AST tools C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant