refactor(ast): re-order generated code#8863
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 3, 2025
Merged
Conversation
Member
Author
This was referenced Feb 3, 2025
CodSpeed Performance ReportMerging #8863 will not alter performanceComparing Summary
|
a9b76af to
14a3737
Compare
32bfaeb to
12a7d4d
Compare
Member
Author
|
No substantive change, so merging without review. |
This was referenced Feb 3, 2025
Member
Author
Merge activity
|
12a7d4d to
bc2b9bb
Compare
This was referenced Feb 3, 2025
Change order in which source files are processed by `oxc_ast_tools`, so `oxc_ast/src/ast/js.rs` is first. This doesn't modify any code, just changes the order of generated methods. Notably `Program` appears first. This will be useful later, for simplifying generation of `Visit` trait.
bc2b9bb to
f6f92db
Compare
This was referenced Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Change order in which source files are processed by
oxc_ast_tools, sooxc_ast/src/ast/js.rsis first. This doesn't modify any code, just changes the order of generated methods. NotablyProgramappears first. This will be useful later, for simplifying generation ofVisittrait.