refactor(ast)!: name AstBuilder enum builders after variant name not type name

[overlookmotel]

Correct what I think is a mistake in the naming of AstBuilder methods for enums. Name the builder methods after the enum variant, not the type of the variant. i.e. AstBuilder::expression_identifier not AstBuilder::expression_identifier_reference, following the variant's name:

oxc/crates/oxc_ast/src/ast/js.rs

Lines 71 to 72 in a302e32

	/// See [`IdentifierReference`] for AST node details.
	Identifier(Box<'a, IdentifierReference<'a>>) = 7,

An enum can have 2 variants with the same type (ExportDefaultDeclarationKind does - Function and Class appear twice to represent function/class declarations and expressions), so naming conflicts are possible, and it's confusing.

Mostly this reduces the length of the methods (jsx_child_jsx_text -> jsx_child_text), but a small minority get longer (export_default_declaration_kind_function -> export_default_declaration_kind_function_declaration).

[overlookmotel]

• fix(ast): fix lifetimes on custom Serialize impls #8899
• refactor(span): combine Span type and impls in 1 file #8900
• refactor(ast): estree via on struct fields implement From #8898
• refactor(ast): override TS type defs with #[estree(custom_ts_def)] attribute on type #8897
• refactor(ast_tools): improve correctness and performance of idents #8895
• refactor(ast_tools): rename is_visited to has_visitor #8893
• refactor(ast_tools): reorder code in Visit generator #8892
• refactor(ast): generate Visit methods in order of type definitions #8891
• refactor(ast)!: name AstBuilder enum builders after variant name not type name #8890 👈 (View in Graphite)
• refactor(ast): record plural names in #[plural] attr #8889
• refactor(ast_tools): shorten code #8888
• feat(ast_tools): get extra params for visitor methods from #[visit(args)] attr #8887
• refactor(ast): shorten generated code for GetSpan #8883
• feat(ast): improve TS type definitions for appended fields #8882
• refactor(ast_tools): parse attributes more deeply #8881
• refactor(ast): derive ContentEq on literal types #8880
• refactor(ast): use = syntax for #[scope] attrs #8878
• refactor(ast): move #[estree(skip)] to types #8877
• refactor(ast): move #[clone_in(default)] to types #8876
• refactor(ast): #[content_eq(skip)] attr #8875
• feat(ast_tools): allow attrs on types which do not derive the trait #8874
• refactor(ast): rename #[estree(always_flatten)] attr to #[estree(flatten)] #8871
• feat(ast_tools): generate mapping of trait name to crate in oxc_ast_macros #8870
• refactor(span)!: export ContentEq trait from root of oxc_span crate #8869
• refactor(ast): communicate type of RegExpFlags to oxc_ast_tools with alias type #8868
• refactor(syntax): add #[ast] attr to semantic ID types #8867
• feat(ast_tools): allow defining foreign types with #[ast(foreign = ...)] #8866
• feat(ast_tools): Support NonZero* primitives #8865
• refactor(ast): shorten generated code for numbers #8864
• refactor(ast): re-order generated code #8863
• refactor(ast): remove unneeded lint attrs from generated code #8862
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #8890 will not alter performance

_{Comparing 02-04-refactor_ast_name_astbuilder_enum_builders_after_variant_name_not_type_name (bbb075d) with 02-04-refactor_ast_record_plural_names_in_plural_attr (893339d)}

Summary

✅ 33 untouched benchmarks

[graphite-app]

Merge activity

• Feb 4, 5:21 PM EST: The Graphite merge queue removed this pull request due to downstack failures on PR #8881.
• Feb 4, 10:29 PM UTC: A user added this pull request to the Graphite merge queue.
• Feb 4, 10:59 PM UTC: A user merged this pull request with the Graphite merge queue.